feat(function): Improved error handling for markdown plugins for items that have no metadata

ref: #40 #42 nofusscomputing/centurion_erp#466

Author: jon-nfc

src/functions/markdown_plugins/ModelLink.js

@@ -48,51 +48,61 @@ function model_link (state) {
     state.pos = start
     state.posMax = end
 
-    if( state.env.models[item_link.groups.model_type][item_link.groups.model_id] ?? null ) {
 
-      const span_o = state.push('span_open', 'span', 1)
-      span_o.attrPush(['class', 'text-inline'])
+    if(
+      (! state.env.models ?? null)
+      || (! state.env.models[item_link.groups?.model_type] ?? null)
+      || (! state.env.models[item_link.groups.model_type][item_link.groups.model_id] ?? null)
+    ) {
 
-        const anchor_o = state.push('a_open', 'a', 1)
-        anchor_o.attrPush(['href', state.env.models[item_link.groups.model_type][item_link.groups.model_id].url])
+      const failed_token = state.push('text', '', 0)
+      failed_token.content = item_link.groups.markdown
 
+      continue
 
-          const icon_o = state.push('icon_open', 'span', 1)
-          icon_o.attrPush([
-            'class', 'badge-icon'
-          ])
+    }
 
-            const icon_t = state.push('html_inline', '', 0)
+    const span_o = state.push('span_open', 'span', 1)
+    span_o.attrPush(['class', 'text-inline'])
 
-            icon_t.content = renderToStaticMarkup(
-              <IconLoader
-                name={String( item_link.groups.model_type ).toLowerCase().replace('kb', 'information')}
-                fill="#777"
-              />
-            )
+      const anchor_o = state.push('a_open', 'a', 1)
+      anchor_o.attrPush(['href', state.env.models[item_link.groups.model_type][item_link.groups.model_id].url])
 
-          const icon_c = state.push('icon_close', 'span', -1)
 
+        const icon_o = state.push('icon_open', 'span', 1)
+        icon_o.attrPush([
+          'class', 'badge-icon'
+        ])
 
-          const anchor_t = state.push('text', '', 0)
-          anchor_t.content = ' ' + state.env.models[item_link.groups.model_type][item_link.groups.model_id].title
+          const icon_t = state.push('html_inline', '', 0)
 
+          icon_t.content = renderToStaticMarkup(
+            <IconLoader
+              name={String( item_link.groups.model_type ).toLowerCase().replace('kb', 'information')}
+              fill="#777"
+            />
+          )
 
-          const item_o = state.push('item_open', 'span', 1)
-            item_o.attrPush(["class", "sub-script metadata"])
+        const icon_c = state.push('icon_close', 'span', -1)
 
-            const item_t = state.push('text', '', 0)
-            item_t.content = ', ' + String( item_link.groups.model_type ) + ' '
 
-          const item_c = state.push('item_close', 'span', -1)
+        const anchor_t = state.push('text', '', 0)
+        anchor_t.content = ' ' + state.env.models[item_link.groups.model_type][item_link.groups.model_id].title
 
 
-        const anchor_c = state.push('a_close', 'a', -1)
+        const item_o = state.push('item_open', 'span', 1)
+          item_o.attrPush(["class", "sub-script metadata"])
 
-      
-      const span_c = state.push('span_close', 'span', -1)
+          const item_t = state.push('text', '', 0)
+          item_t.content = ', ' + String( item_link.groups.model_type ) + ' '
 
-    }
+        const item_c = state.push('item_close', 'span', -1)
+
+
+      const anchor_c = state.push('a_close', 'a', -1)
+
+    
+    const span_c = state.push('span_close', 'span', -1)
 
   }
 

src/functions/markdown_plugins/TicketLink.js

@@ -51,59 +51,71 @@ function ticket_link (state, silent) {
     state.pos = start
     state.posMax = end
 
-    if( state.env.tickets[item_link.groups.model_id] ?? null ) {
 
-      const span_o = state.push('span_open', 'span', 1)
-      span_o.attrPush(['class', 'text-inline'])
+    if(
+      (! state.env.tickets ?? null)
+      || (! state.env.tickets[item_link.groups?.model_type] ?? null)
+      || (! state.env.tickets[item_link.groups.model_type][item_link.groups.model_id] ?? null)
+    ) {
 
-        const anchor_o = state.push('a_open', 'a', 1)
-        anchor_o.attrPush(['href', state.env.tickets[item_link.groups.model_id].url])
+      const failed_token = state.push('text', '', 0)
+      failed_token.content = item_link.groups.markdown
 
+      continue
 
-          const icon_o = state.push('icon_open', 'span', 1)
-          icon_o.attrPush([
-            'class', 'badge-icon ticket-status-icon ticket-status-icon-' + String(state.env.tickets[item_link.groups.model_id].status).toLowerCase().replace(' ', '_').replace('(', '').replace(')', '')
-          ])
+    }
 
-            const icon_t = state.push('html_inline', '', 0)
 
-            icon_t.content = renderToStaticMarkup(
-              <IconLoader
-                name={'ticket_status_new'}
-              />
-            )
+    const span_o = state.push('span_open', 'span', 1)
+    span_o.attrPush(['class', 'text-inline'])
 
-          const icon_c = state.push('icon_close', 'span', -1)
+      const anchor_o = state.push('a_open', 'a', 1)
+      anchor_o.attrPush(['href', state.env.tickets[item_link.groups.model_id].url])
 
 
-          const ref_o = state.push('ref_open', 'span', 1)
-            ref_o.attrPush(["class", "sub-script metadata"])
+        const icon_o = state.push('icon_open', 'span', 1)
+        icon_o.attrPush([
+          'class', 'badge-icon ticket-status-icon ticket-status-icon-' + String(state.env.tickets[item_link.groups.model_id].status).toLowerCase().replace(' ', '_').replace('(', '').replace(')', '')
+        ])
 
-            const ref_t = state.push('text', '', 0)
-            ref_t.content = ' #' + String( item_link.groups.model_id ) + ' '
+          const icon_t = state.push('html_inline', '', 0)
 
-          const ref_c = state.push('ref_close', 'span', -1)
+          icon_t.content = renderToStaticMarkup(
+            <IconLoader
+              name={'ticket_status_new'}
+            />
+          )
 
+        const icon_c = state.push('icon_close', 'span', -1)
 
-          const anchor_t = state.push('text', '', 0)
-          anchor_t.content = state.env.tickets[item_link.groups.model_id].title
 
+        const ref_o = state.push('ref_open', 'span', 1)
+          ref_o.attrPush(["class", "sub-script metadata"])
 
-          const item_o = state.push('item_open', 'span', 1)
-            item_o.attrPush(["class", "sub-script metadata"])
+          const ref_t = state.push('text', '', 0)
+          ref_t.content = ' #' + String( item_link.groups.model_id ) + ' '
 
-            const item_t = state.push('text', '', 0)
-            item_t.content = ', ' + String( state.env.tickets[item_link.groups.model_id].ticket_type ) + ' '
+        const ref_c = state.push('ref_close', 'span', -1)
 
-          const item_c = state.push('item_close', 'span', -1)
 
+        const anchor_t = state.push('text', '', 0)
+        anchor_t.content = state.env.tickets[item_link.groups.model_id].title
 
-        const anchor_c = state.push('a_close', 'a', -1)
 
-      
-      const span_c = state.push('span_close', 'span', -1)
+        const item_o = state.push('item_open', 'span', 1)
+          item_o.attrPush(["class", "sub-script metadata"])
+
+          const item_t = state.push('text', '', 0)
+          item_t.content = ', ' + String( state.env.tickets[item_link.groups.model_id].ticket_type ) + ' '
+
+        const item_c = state.push('item_close', 'span', -1)
+
+
+      const anchor_c = state.push('a_close', 'a', -1)
+
+    
+    const span_c = state.push('span_close', 'span', -1)
 
-    }
 
   }