Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✔ views must cache the serializer #513

Closed
1 task
jon-nfc opened this issue Feb 1, 2025 · 0 comments · Fixed by #518
Closed
1 task

✔ views must cache the serializer #513

jon-nfc opened this issue Feb 1, 2025 · 0 comments · Fixed by #518
Assignees
@jon-nfc
Labels
task::test Testing and related items type::task Issue Type
Milestone
v1.9

Comments

@jon-nfc
Copy link
Member

jon-nfc commented Feb 1, 2025

all views must cache the serializer. without this there will be duplicated DB queries in a majority of cases

Tasks

  • write unit test to confirm view is caching the serailizer
@jon-nfc jon-nfc added task::test Testing and related items type::task Issue Type labels Feb 1, 2025
@jon-nfc jon-nfc added this to the Next Release milestone Feb 1, 2025
@jon-nfc jon-nfc moved this to Planning in Centurion ERP Feb 1, 2025
@jon-nfc jon-nfc moved this from Planning to Backlog in Centurion ERP Feb 1, 2025
@jon-nfc jon-nfc self-assigned this Feb 3, 2025
@jon-nfc jon-nfc moved this from Backlog to In progress in Centurion ERP Feb 3, 2025
@jon-nfc jon-nfc mentioned this issue Feb 3, 2025
Merged
9 tasks
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(base): Ensure viewsets are caching and using the serializer_clas…
4032db7 
…s object

ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(access): Add missing unit tests for organization viewset
e4bb668 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(access): Add missing unit tests for team viewset
3baae78 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(access): Add missing unit tests for team user viewset
d9aa749 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
fix(access): Team viewset must cache serializer_class
bde8940 
ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(assistance): Add missing unit tests for Knowledge Base viewset
7c9974d 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(assistance): Add missing unit tests for Knowledge Base Category …
9202d45 
…viewset

ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(assistance): Add missing unit tests for Model Knowledge Base Art…
d5f0af6 
…icle viewset

ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
fix(assistance): Team viewset must cache serializer_class
3cfee35 
ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(config_management): Add missing unit tests for config groups vie…
4a58a93 
…wset

ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(config_management): Add missing unit tests for config groups sof…
02659bb 
…tware viewset

ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(core): Add missing unit tests for manufacturer viewset
68059ef 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(core): Add missing unit tests for Ticket Category viewset
bf63553 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(core): Add missing unit tests for Ticket Comment Category viewset
a932d86 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(access): Add missing unit tests for organization viewset
a5b5a34 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(access): Add missing unit tests for team viewset
40c5a5e 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(access): Add missing unit tests for team user viewset
2e17fc2 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
fix(access): Team viewset must cache serializer_class
7b74f6c 
ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
fix(access): Team viewset must cache serializer_class
215b771 
ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 3, 2025
@jon-nfc
test(access): Add missing unit tests for team viewset
b0eb261 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(api): Add kwargs as arg to test cases
bb99b89 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itam): Add missing unit tests for device operating system viewset
02afaf2 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itam): Add missing unit tests for device software viewset
18ddd92 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itam): Add missing unit tests for os installs viewset
d608a3d 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itam): Add missing unit tests for software installs viewset
c54c54d 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itam): Add missing unit tests for os versions viewset
c907efb 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itam): Add missing unit tests for software categories viewset
b9c4228 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itam): Add missing unit tests for software version viewset
0338e5c 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
fix(itam): correct truthy check for device os ViewSet property when e…
84499bf 
…valuating serializer_class

ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
fix(itam): correct truthy check for device software ViewSet property …
9c2b0cb 
…when evaluating serializer_class

ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
fix(itam): correct truthy check for os version ViewSet property when …
4eec08f 
…evaluating serializer_class

ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
fix(itam): correct truthy check for software category ViewSet propert…
184f775 
…y when evaluating serializer_class

ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
fix(itam): correct truthy check for software version ViewSet property…
efc95ef 
… when evaluating serializer_class

ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
fix(api): correct get_view_name to prioritize view_name over model.ve…
c755feb 
…rbose_name

ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test: Add empty kwargs to ViewSet index page test cases
83fb6d0 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itim): Add missing unit tests for change ticket viewset
bac22d6 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itim): Add missing unit tests for incident ticket viewset
29443a5 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(itim): Add missing unit tests for problem ticket viewset
16199cb 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
fix(itam): correct truthy check for service device ViewSet property w…
2e321d2 
…hen evaluating serializer_class

ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
fix(itam): correct truthy check for service cluster ViewSet property …
c508cfc 
…when evaluating serializer_class

ref: #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(api): Add kwargs as arg to test cases
0db2c09 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(project_management): Add missing unit tests for project task tic…
73c3f0a 
…ket viewset

ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
chore(itim): correct var name within function get_serializer_class
af0b05c 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(settings): Add missing unit tests for app settings ticket viewset
91e83b0 
ref: #512 #513 #518
jon-nfc added a commit that referenced this issue Feb 6, 2025
@jon-nfc
test(settings): Add missing unit tests for user settings ticket viewset
5d83320 
ref: #512 #513 #518
@jon-nfc jon-nfc linked a pull request Feb 6, 2025 that will close this issue
test(base): Ensure viewsets are caching and using the queryset and serializer_class objects #518
Merged
9 tasks
@jon-nfc jon-nfc moved this from In progress to Done in Centurion ERP Feb 6, 2025
@jon-nfc jon-nfc changed the title views must cache the serializer ✔ views must cache the serializer Feb 6, 2025
@jon-nfc jon-nfc closed this as completed in aa9c0c7 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jon-nfc jon-nfc

Labels
task::test Testing and related items type::task Issue Type
Projects
Centurion ERP
Status: Done
Milestone
v1.9
1 participant
@jon-nfc