Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Ticket get_permission_required #457

Open
1 task
Tracked by #442
jon-nfc opened this issue Dec 28, 2024 · 0 comments
Open
1 task
Tracked by #442

Refactor Ticket get_permission_required #457

jon-nfc opened this issue Dec 28, 2024 · 0 comments
Labels
task::refactor type::task Issue Type

Comments

@jon-nfc
Copy link
Member

jon-nfc commented Dec 28, 2024 •
edited
Loading

Function get_permission_required is only required to return the required permission for the viewset. app/core/viewsets/ticket.py conducts more actions that are not required.

Details

get_permission_required for ticket.py does actual permission checking. this is not required.

Tasks

  • Refactor get_permission_required to return the permission only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task::refactor type::task Issue Type
Projects
Centurion ERP
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jon-nfc