fix(api): Ensure ALL required classes for viewset are inherited

ref: #459

Author: jon-nfc

app/core/lib/slash_commands/linked_model.py

@@ -77,121 +77,136 @@ def command_linked_model(self, match) -> str:
 
         try:
 
-            from core.models.ticket.ticket_linked_items import TicketLinkedItem
+            model, item_type = self.get_model( model_type )
 
-            if model_type == 'cluster':
+            if not model:
 
-                from itim.models.clusters import Cluster
+                return str(match.string[match.start():match.end()])
 
-                model = Cluster
 
-                item_type = TicketLinkedItem.Modules.CLUSTER
+            if str(self._meta.verbose_name).lower() == 'ticket':
 
-            elif model_type == 'config_group':
+                ticket = self
 
-                from config_management.models.groups import ConfigGroups
+            elif str(self._meta.verbose_name).lower() == 'ticket comment':
 
-                model = ConfigGroups
+                ticket = self.ticket
 
-                item_type = TicketLinkedItem.Modules.CONFIG_GROUP
 
-            elif model_type == 'device':
+            if model:
 
-                from itam.models.device import Device
+                item = model.objects.get(
+                    pk = model_id
+                )
 
-                model = Device
+                from core.serializers.ticket_linked_item import TicketLinkedItemModelSerializer
 
-                item_type = TicketLinkedItem.Modules.DEVICE
+                serializer = TicketLinkedItemModelSerializer(
+                    data = {
+                        'organization': ticket.organization,
+                        'ticket': ticket.id,
+                        'item_type': item_type,
+                        'item': item.id
+                    }
+                )
 
-            elif model_type == 'kb':
+                if serializer.is_valid():
 
-                from assistance.models.knowledge_base import KnowledgeBase
+                    serializer.save()
 
-                model = KnowledgeBase
+                    return None
 
-                item_type = TicketLinkedItem.Modules.KB
+                return str(match.string[match.start():match.end()])
 
-            elif  model_type == 'operating_system':
+        except Exception as e:
 
-                from itam.models.operating_system import OperatingSystem
+            return str(match.string[match.start():match.end()])
 
-                model = OperatingSystem
+        return None
 
-                item_type = TicketLinkedItem.Modules.OPERATING_SYSTEM
 
-            elif  model_type == 'organization':
+    def get_model(self, model_type) -> tuple():
 
-                from access.models import Organization
+        model = None
 
-                model = Organization
+        item_type = None
 
-                item_type = TicketLinkedItem.Modules.ORGANIZATION
+        from core.models.ticket.ticket_linked_items import TicketLinkedItem
 
-            elif model_type == 'service':
+        if model_type == 'cluster':
 
-                from itim.models.services import Service
+            from itim.models.clusters import Cluster
 
-                model = Service
+            model = Cluster
 
-                item_type = TicketLinkedItem.Modules.SERVICE
+            item_type = TicketLinkedItem.Modules.CLUSTER
 
-            elif model_type == 'software':
+        elif model_type == 'config_group':
 
-                from itam.models.software import Software
+            from config_management.models.groups import ConfigGroups
 
-                model = Software
+            model = ConfigGroups
 
-                item_type = TicketLinkedItem.Modules.SOFTWARE
+            item_type = TicketLinkedItem.Modules.CONFIG_GROUP
 
-            elif model_type == 'team':
+        elif model_type == 'device':
 
-                from access.models import Team
+            from itam.models.device import Device
 
-                model = Team
+            model = Device
 
-                item_type = TicketLinkedItem.Modules.TEAM
+            item_type = TicketLinkedItem.Modules.DEVICE
 
-            else:
+        elif model_type == 'kb':
 
-                return str(match.string[match.start():match.end()])
+            from assistance.models.knowledge_base import KnowledgeBase
 
+            model = KnowledgeBase
 
-            if str(self._meta.verbose_name).lower() == 'ticket':
+            item_type = TicketLinkedItem.Modules.KB
 
-                ticket = self
+        elif  model_type == 'operating_system':
 
-            elif str(self._meta.verbose_name).lower() == 'ticket comment':
+            from itam.models.operating_system import OperatingSystem
 
-                ticket = self.ticket
+            model = OperatingSystem
 
+            item_type = TicketLinkedItem.Modules.OPERATING_SYSTEM
 
-            if model:
+        elif  model_type == 'organization':
 
-                item = model.objects.get(
-                    pk = model_id
-                )
+            from access.models import Organization
 
-                from core.serializers.ticket_linked_item import TicketLinkedItemModelSerializer
+            model = Organization
 
-                serializer = TicketLinkedItemModelSerializer(
-                    data = {
-                        'organization': ticket.organization,
-                        'ticket': ticket.id,
-                        'item_type': item_type,
-                        'item': item.id
-                    }
-                )
+            item_type = TicketLinkedItem.Modules.ORGANIZATION
 
-                if serializer.is_valid():
+        elif model_type == 'service':
 
-                    serializer.save()
+            from itim.models.services import Service
 
-                    return None
+            model = Service
 
-                return str(match.string[match.start():match.end()])
+            item_type = TicketLinkedItem.Modules.SERVICE
 
-        except Exception as e:
+        elif model_type == 'software':
 
-            return str(match.string[match.start():match.end()])
+            from itam.models.software import Software
 
-        return None
+            model = Software
+
+            item_type = TicketLinkedItem.Modules.SOFTWARE
+
+        elif model_type == 'team':
+
+            from access.models import Team
+
+            model = Team
+
+            item_type = TicketLinkedItem.Modules.TEAM
+
+
+        return tuple([
+            model,
+            item_type
+        ])