Wrong html image attributes set by featherlight

[designseer]

Hello,

This is one of the issues everyone has. The image in lightbox modal window is always 1px less in width and height.

Problem is negligible but screenshot of text looks blurred when the final image is resized by 1px.

Need an example from my website? No need as I can show this issue on the plugin website itself.
https://noelboss.github.io/featherlight/

Click on Image. (droplets.jpg)

Real Resolution of droplets.jpg = 1000 x 700

Featherlight resolution = 999 x 699

[marcandre]

It's definitely possible there's a rounding error in the resizing code. A PR would be most welcome.

[spylypenko]

Hello, I have investigated this issue.
It is caused by this old hack d605014

I think this hack is not useful anymore.
The ratio calculation included padding and border of the container, and it was the real reason why the scrollbars appeared.
The current version uses the content width and height, so I think it is safe to remove -1 here:

featherlight/src/featherlight.js

Lines 359 to 360 in 3d6bd02

	w / (this.$content.parent().width()-1),
	h / (this.$content.parent().height()-1));

Could you please confirm if this is ok.