-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQTT module has static DNS handling #2987
Comments
This was referenced Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The MQTT module nominally can juggle multiple clients, each with an associated lightuserdata object, and yet it contains "static ip_addr_t host_ip; // for dns". So in practice it can only be doing one DNS resolution at once and may end up crisscrossing resolution results between multiple client objects.
I think I would like to make a breaking change to the C module: no DNS support for the hostname. We can (I will) provide a Lua wrapper that does DNS resolution and hands the address down to the
mqtt
module. (As with #2819, I want to keep the C as simple as possible; for MQTT, keeping the state machine in C is fine, I guess, since it's already there and working.)The text was updated successfully, but these errors were encountered: