WIP

Author: AugustinMauroy

recipes/repl-builtin-modules/src/workflow.ts

@@ -1,6 +1,7 @@
 import { EOL } from "node:os";
 import { getNodeImportStatements } from "@nodejs/codemod-utils/ast-grep/import-statement";
 import { getNodeRequireCalls } from "@nodejs/codemod-utils/ast-grep/require-call";
+import { resolveBindingPath } from "@nodejs/codemod-utils/ast-grep/resolve-binding-path";
 import type { SgRoot, Edit, SgNode } from "@codemod.com/jssg-types/main";
 import type Js from "@codemod.com/jssg-types/langs/javascript";
 
@@ -147,28 +148,36 @@ export default function transform(root: SgRoot<Js>): string | null {
         } else {
             // Handle namespace require (const repl = require('node:repl'))
             const variableDeclarator = statement.find({ rule: { kind: "variable_declarator" } });
-            const identifier = variableDeclarator?.find({ rule: { kind: "identifier" } });
-
-            if (identifier) {
-                const varName = identifier.text();
-                const usages = rootNode.findAll({
-                    rule: {
-                        any: [
-                            { pattern: `${varName}.builtinModules` },
-                            { pattern: `${varName}._builtinLibs` }
-                        ]
-                    }
-                });
 
-                if (usages.length > 0) {
-                    edits.push(identifier.replace("module"));
-                    updateModuleSpecifier(statement);
+            if (variableDeclarator) {
+				// Use resolveBindingPath to determine how builtinModules should be accessed
+				const builtinModulesPath = resolveBindingPath(variableDeclarator, "$.builtinModules");
+				const builtinLibsPath = resolveBindingPath(variableDeclarator, "$._builtinLibs");
+
+				const usages = rootNode.findAll({
+					rule: {
+						any: [
+							{ pattern: builtinModulesPath },
+							{ pattern: builtinLibsPath }
+						]
+					}
+				});
 
-                    for (const memberExpr of usages) {
-                        edits.push(memberExpr.replace("module.builtinModules"));
-                    }
-                    hasChanges = true;
-                }
+				if (usages.length > 0) {
+					const identifier = variableDeclarator.find({
+						rule: { kind: "identifier" }
+					});
+
+					if (identifier) {
+						edits.push(identifier.replace("module"));
+						updateModuleSpecifier(statement);
+
+						for (const memberExpr of usages) {
+							edits.push(memberExpr.replace("module.builtinModules"));
+						}
+						hasChanges = true;
+					}
+				}
             }
         }
     }
@@ -235,35 +244,37 @@ export default function transform(root: SgRoot<Js>): string | null {
             const importClause = statement.find({ rule: { kind: "import_clause" } });
             if (!importClause) continue;
 
-            let importIdentifier = importClause.find({ rule: { kind: "identifier" } });
-
-            if (!importIdentifier) {
-                const namespaceImport = importClause.find({ rule: { kind: "namespace_import" } });
-                if (namespaceImport) {
-                    importIdentifier = namespaceImport.find({ rule: { kind: "identifier" } });
-                }
-            }
-
-            if (importIdentifier) {
-                const varName = importIdentifier.text();
-                const expressions = rootNode.findAll({
-                    rule: {
-                        any: [
-                            { pattern: `${varName}.builtinModules` },
-                            { pattern: `${varName}._builtinLibs` }
-                        ]
-                    }
-                });
-
-                if (expressions.length > 0) {
-                    updateModuleSpecifier(statement);
-
-                    for (const memberExpr of expressions) {
-                        edits.push(memberExpr.replace(`${varName}.builtinModules`));
-                    }
-                    hasChanges = true;
-                }
-            }
+			// Use resolveBindingPath to determine how builtinModules should be accessed
+			const builtinModulesPath = resolveBindingPath(importClause, "$.builtinModules");
+			const builtinLibsPath = resolveBindingPath(importClause, "$._builtinLibs");
+
+			const expressions = rootNode.findAll({
+				rule: {
+					any: [
+						{ pattern: builtinModulesPath },
+						{ pattern: builtinLibsPath }
+					]
+				}
+			});
+
+			if (expressions.length > 0) {
+				updateModuleSpecifier(statement);
+
+				// Get the namespace identifier to maintain consistency
+				let importIdentifier = importClause.find({ rule: { kind: "identifier" } });
+				if (!importIdentifier) {
+					const namespaceImport = importClause.find({ rule: { kind: "namespace_import" } });
+					if (namespaceImport) {
+						importIdentifier = namespaceImport.find({ rule: { kind: "identifier" } });
+					}
+				}
+
+				const varName = importIdentifier?.text() || "module";
+				for (const memberExpr of expressions) {
+					edits.push(memberExpr.replace(`${varName}.builtinModules`));
+				}
+				hasChanges = true;
+			}
         }
     }