used validateinteger

Author: amyssnippet

lib/internal/http2/core.js

@@ -5,7 +5,6 @@ const {
   ArrayIsArray,
   MathMin,
   Number,
-  NumberIsFinite,
   ObjectAssign,
   ObjectDefineProperty,
   ObjectEntries,
@@ -3398,12 +3397,12 @@ class Http2SecureServer extends TLSServer {
         this.keepAliveTimeout = 5_000; // 5 seconds;
       }
       const keepAliveTimeoutBuffer = options.keepAliveTimeoutBuffer;
-      // Optional buffer added to the keep-alive timeout when setting socket timeouts.
-      // Helps reduce ECONNRESET errors from clients by extending the internal timeout.
-      // Default is 1000ms if not specified.
-      const buf = keepAliveTimeoutBuffer;
-      this.keepAliveTimeoutBuffer =
-        (typeof buf === 'number' && NumberIsFinite(buf) && buf >= 0) ? buf : 1000;
+      if (keepAliveTimeoutBuffer !== undefined) {
+        validateInteger(keepAliveTimeoutBuffer, 'keepAliveTimeoutBuffer', 0);
+        this.keepAliveTimeoutBuffer = keepAliveTimeoutBuffer;
+      } else {
+        this.keepAliveTimeoutBuffer = 1000;
+      }
       this.shouldUpgradeCallback = function() {
         return this.listenerCount('upgrade') > 0;
       };

test/parallel/test-http2-https-fallback-http-server-options.js

@@ -21,8 +21,10 @@ function onRequest(request, response) {
   const { socket: { alpnProtocol } } = request.httpVersion === '2.0' ?
     request.stream.session : request;
   // Verify that keepAliveTimeout is set when allowHTTP1 is true
-  assert.strictEqual(typeof request.socket.server.keepAliveTimeout, 'number');
-  assert.strictEqual(request.socket.server.keepAliveTimeout, 5000);
+  if (request.httpVersion === '1.1') {
+    assert.strictEqual(typeof request.socket.server.keepAliveTimeout, 'number');
+    assert.strictEqual(request.socket.server.keepAliveTimeout, 5000);
+  }
   response.status(200);
   response.end(JSON.stringify({
     alpnProtocol,