Skip to content

Commit 38b97a8

Browse files
committed
deps: remove corepack
Fixes: #51888
1 parent 384fd17 commit 38b97a8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

76 files changed

+30
-26175
lines changed

.gitattributes

-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@ test/fixtures/* -text
22
vcbuild.bat text eol=crlf
33
deps/npm/bin/npm text eol=lf
44
deps/npm/bin/npx text eol=lf
5-
deps/corepack/shims/corepack text eol=lf
65
tools/msvs/find_python.cmd text eol=crlf

.github/workflows/tools.yml

-7
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ on:
2020
- brotli
2121
- c-ares
2222
- cjs-module-lexer
23-
- corepack
2423
- doc
2524
- eslint
2625
- github_reporter
@@ -112,12 +111,6 @@ jobs:
112111
cat temp-output
113112
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
114113
rm temp-output
115-
- id: corepack
116-
subsystem: deps
117-
label: dependencies
118-
run: |
119-
make corepack-update
120-
echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV
121114
- id: doc
122115
subsystem: tools
123116
label: tools

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ _UpgradeReport_Files/
6666
*.wixobj
6767
/tools/msvs/genfiles/
6868
/npm.wxs
69-
/corepack.wxs
7069
/tools/msvs/msi/**/Release/
7170
/tools/msvs/msi/**/obj/
7271
/tools/msvs/msi/**/x64/

LICENSE

-11
Original file line numberDiff line numberDiff line change
@@ -726,17 +726,6 @@ The externally maintained libraries used by Node.js are:
726726
USE OR OTHER DEALINGS IN THE SOFTWARE.
727727
"""
728728

729-
- corepack, located at deps/corepack, is licensed as follows:
730-
"""
731-
**Copyright © Corepack contributors**
732-
733-
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
734-
735-
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
736-
737-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
738-
"""
739-
740729
- undici, located at deps/undici, is licensed as follows:
741730
"""
742731
MIT License

Makefile

-11
Original file line numberDiff line numberDiff line change
@@ -1143,17 +1143,6 @@ endif
11431143
# Builds the macOS installer for releases.
11441144
pkg: $(PKG)
11451145

1146-
.PHONY: corepack-update
1147-
corepack-update:
1148-
mkdir -p /tmp/node-corepack
1149-
curl -qLo /tmp/node-corepack/package.tgz "$$(npm view corepack dist.tarball)"
1150-
1151-
rm -rf deps/corepack && mkdir deps/corepack
1152-
cd deps/corepack && tar xf /tmp/node-corepack/package.tgz --strip-components=1
1153-
chmod +x deps/corepack/shims/*
1154-
1155-
node deps/corepack/dist/corepack.js --version
1156-
11571146
.PHONY: pkg-upload
11581147
# Note: this is strictly for release builds on release machines only.
11591148
pkg-upload: pkg

SECURITY.md

-7
Original file line numberDiff line numberDiff line change
@@ -201,13 +201,6 @@ the community they pose.
201201
that artifact is large enough to impact performance or
202202
cause the runtime to run out of resources.
203203

204-
#### Vulnerabilities affecting software downloaded by Corepack
205-
206-
* Corepack defaults to downloading the latest version of the software requested
207-
by the user, or a specific version requested by the user. For this reason,
208-
Node.js releases won't be affected by such vulnerabilities, users are
209-
responsible to keep the software they use through Corepack up-to-date.
210-
211204
## Assessing experimental features reports
212205

213206
Experimental features are eligible to reports as any other stable feature of

benchmark/misc/startup-cli-version.js

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ const bench = common.createBenchmark(main, {
1414
'tools/node_modules/eslint/bin/eslint.js',
1515
'deps/npm/bin/npx-cli.js',
1616
'deps/npm/bin/npm-cli.js',
17-
'deps/corepack/dist/corepack.js',
1817
],
1918
count: [30],
2019
});

configure.py

-7
Original file line numberDiff line numberDiff line change
@@ -668,12 +668,6 @@
668668
default=None,
669669
help='do not install the bundled npm (package manager)')
670670

671-
parser.add_argument('--without-corepack',
672-
action='store_true',
673-
dest='without_corepack',
674-
default=None,
675-
help='do not install the bundled Corepack')
676-
677671
# Dummy option for backwards compatibility
678672
parser.add_argument('--without-report',
679673
action='store_true',
@@ -1254,7 +1248,6 @@ def configure_node(o):
12541248
o['variables']['OS'] = 'android'
12551249
o['variables']['node_prefix'] = options.prefix
12561250
o['variables']['node_install_npm'] = b(not options.without_npm)
1257-
o['variables']['node_install_corepack'] = b(not options.without_corepack)
12581251
o['variables']['debug_node'] = b(options.debug_node)
12591252
o['default_configuration'] = 'Debug' if options.debug else 'Release'
12601253
o['variables']['error_on_warn'] = b(options.error_on_warn)

0 commit comments

Comments
 (0)