Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update better-sqlite3 to >= 11.5.0 #592

Closed
2 tasks done
MikeMcC399 opened this issue Jan 13, 2025 · 1 comment · Fixed by #594
Closed
2 tasks done

Update better-sqlite3 to >= 11.5.0 #592

MikeMcC399 opened this issue Jan 13, 2025 · 1 comment · Fixed by #594

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jan 13, 2025

What would you like?

  1. Update better-sqlite3 to >= [email protected]. Latest version is currently [email protected]
  2. Drop support for Node.js 21 (package.json engines and ci.yml)
  3. Add CI testing in Node.js 23 (ci.yml)

Why is this needed?

  1. Node.js 23 was released on Oct 15, 2024 and is the "current" version. It should be tested in CI. Node.js v23.6.0 documentation includes it in the corepack section of the documentation.
  2. better-sqlite3 support for Node.js 23 was introduced in [email protected]. This is the minimum version required to run yarn install successfully with Node.js 23. yarn install is a prerequisite to run yarn build and yarn test.
  3. [email protected] dropped support for Node.js 21
  4. There is no version of better-sqlite3 which supports both Node.js 21 and 23 (see also comments in chore: bump better-sqlite3 to 10.x #513 from @wojtekmaj).
  5. Node.js 21 entered end-of-life on Jun 6, 2024. It should no longer be tested in CI since it is now unsupported.

Other

PRs

  1. Drop Node.js 21 support
  2. Update better-sqlite3 to >= 11.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant