Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests assume COREPACK_ENABLE_STRICT unset #303

Closed
rotu opened this issue Sep 4, 2023 · 1 comment · Fixed by #304
Closed

Tests assume COREPACK_ENABLE_STRICT unset #303

rotu opened this issue Sep 4, 2023 · 1 comment · Fixed by #304

Comments

@rotu
Copy link

rotu commented Sep 4, 2023

In my shell profile, I export COREPACK_ENABLE_STRICT=0. This causes the test to fail, since the "should refuse to run a different package manager within a configured project" test assumes this environment variable is unset.

https://github.com/nodejs/corepack/blob/2bf76c9e29a59dee21e96cf6250a8cede59922e5/tests/main.test.ts#L262C28-L262C28
styfle added a commit to styfle/corepack that referenced this issue Sep 4, 2023
@styfle
chore: update test to handle case when env var is set
b6d4103 
- Fixes nodejs#303
@styfle styfle mentioned this issue Sep 4, 2023
Merged
@styfle
Copy link
Member

styfle commented Sep 4, 2023

This should fix it #304

arcanis pushed a commit that referenced this issue Sep 4, 2023
@styfle
chore: update test to handle case when env var is set (#304)
cc33de0 
* chore: update test to handle case when env var is set

- Fixes #303

* revert

* delete env vars in setupTests.js

* remove newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update test to handle case when env var is set styfle/corepack
2 participants
@rotu @styfle