From db6fae50cf44884d1e9a6f7e99402e7e807ba3ca Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 12 Jul 2024 10:43:09 +0200 Subject: [PATCH] fix: replace npm registry domain in tarball URL (#502) --- sources/corepackUtils.ts | 9 ++++----- tests/_registryServer.mjs | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/sources/corepackUtils.ts b/sources/corepackUtils.ts index a1f3a0851..6a4436ab8 100644 --- a/sources/corepackUtils.ts +++ b/sources/corepackUtils.ts @@ -230,12 +230,11 @@ export async function installVersion(installTarget: string, locator: Locator, {s if (registry.bin) { binPath = registry.bin; } - } else { - url = url.replace( - npmRegistryUtils.DEFAULT_NPM_REGISTRY_URL, - () => process.env.COREPACK_NPM_REGISTRY!, - ); } + url = url.replace( + npmRegistryUtils.DEFAULT_NPM_REGISTRY_URL, + () => process.env.COREPACK_NPM_REGISTRY!, + ); } } else { url = decodeURIComponent(version); diff --git a/tests/_registryServer.mjs b/tests/_registryServer.mjs index d051b0a66..d616fa2fc 100644 --- a/tests/_registryServer.mjs +++ b/tests/_registryServer.mjs @@ -104,7 +104,7 @@ function generateVersionMetadata(packageName, version) { shasum, size: mockPackageTarGz.length, noattachment: false, - tarball: `${process.env.COREPACK_NPM_REGISTRY}/${packageName}/-/${packageName}-${version}.tgz`, + tarball: `https://registry.npmjs.org/${packageName}/-/${packageName}-${version}.tgz`, ...generateSignature(packageName, version), }, };