Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding Accept-Post and Accept-Put #935

Closed
RubenVerborgh opened this issue Nov 14, 2018 · 10 comments
Closed

Consider adding Accept-Post and Accept-Put #935

RubenVerborgh opened this issue Nov 14, 2018 · 10 comments
Labels

Comments

@RubenVerborgh
Copy link
Contributor

No description provided.

@RubenVerborgh
Copy link
Contributor Author

Given #934 (comment), does not depend on auth status.

@dmitrizagidulin
Copy link
Contributor

Is this not already handled by the WAC-Allow: header?

@dmitrizagidulin
Copy link
Contributor

Ahh, ok, got it.

@namedgraph
Copy link

What's the rationale for more non-standard headers when plain Accept is enough?

@csarven
Copy link
Member

csarven commented Dec 8, 2018

@namedgraph FYI, this issue was derived from #931 . Usually leaving some provenance helps future readers.

Accept is too broad in context of OPTIONS. Not to mention that it'll probably interpreted for the OPTIONS itself.

For each method, it is useful to distinguish between acceptable mimetypes. Unless a server is capable of handling the same values for each allowed method, then sure, Accept alone would be sufficient, in theory. Even then, I don't think that's a good idea. There is also no evidence that a LD server that Accepts text/html is going to take on a PATCH with text/html - just to take an example. Take my word for it ;)

There is sufficient "standard" talk re Accept-Post and Accept-Patch. Accept-Put doesn't ( also mentioned in #931 (comment) ). It doesn't matter. Just implement something that's sufficiently aligned with other stuff - consider it as incubation - and then bump it up to standards given that there was some experimentation and experience.

@namedgraph
Copy link

@csarven so in what situations should Accept-Post and Accept-Patch be sent? With every response?
We support all the serializations that Jena supports, so that becomes an extensive list:

Accept-Put: application/rdf+xml,application/n-quads,text/rdf+n3,application/n-triples,text/csv,application/ld+json,application/rdf+xml,application/rdf+thrift,text/turtle,application/rdf+json,text/trig
Accept-Post: application/rdf+xml,application/n-quads,text/rdf+n3,application/n-triples,text/csv,application/ld+json,application/rdf+xml,application/rdf+thrift,text/turtle,application/rdf+json,text/trig

That's quite an overhead to send with every response, don't you think? But I guess we can live with that.

@kjetilk
Copy link
Member

kjetilk commented Dec 20, 2018

I think we should start using RDF more, so that we can have in-band semantics... :-) Perhaps a .controls resource or something. This isn't my primary use case for it, but headers are starting to get pretty verbose.

@csarven
Copy link
Member

csarven commented Dec 20, 2018

@namedgraph Why every response? Send only when responding to OPTIONS.

@namedgraph
Copy link

@kjetilk not so simple. First you would need semantics of what .controls means and how it is discoverable.

@csarven
Copy link
Member

csarven commented Oct 12, 2024

AFAICT, this issue is resolved at the very least by PR: #1754

@csarven csarven closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants