Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructing a Dataset in memory does not mark tensors as external #97

Open
stellaraccident opened this issue Jul 9, 2024 · 0 comments

Comments

@stellaraccident
Copy link
Contributor

Currently, the act of saving/loading a Dataset is what attaches the external trait to tensors, which upon export of a model will result in external parameter globals vs inline/constants.

It should be possible to write a simple test to verify that in-memory creation/modification of a Theta, without round-tripping to disk does the right thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant