Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must set annotationType before annotationColor #8

Open
pevensen opened this issue Apr 15, 2014 · 1 comment
Open

Must set annotationType before annotationColor #8

pevensen opened this issue Apr 15, 2014 · 1 comment

Comments

@pevensen
Copy link

I discovered that one must set annotationType before annotationColor, as setting the color generates the image.

It seems unusual for a setter to have such side-effects. One should be able to set either in either order. Would it be possible to either regenerate the image on each setter or delay generating the image until it is actually need. This way the setters could be called in either order.

At the very least, please update the documentation to say that one must set type type first.

@nnhubbard
Copy link
Owner

Yeah, this was written a long time ago and needs an update. If you have time to do a pull request that would be great. If not I will try to get to fixing this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants