Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace macros are not respected in many instances #4484

Open
1 of 2 tasks
iboB opened this issue Nov 4, 2024 · 2 comments
Open
1 of 2 tasks

Namespace macros are not respected in many instances #4484

iboB opened this issue Nov 4, 2024 · 2 comments

Comments

@iboB
Copy link

iboB commented Nov 4, 2024

Description

It may be the case that the feature is abandoned, but the macros seem to be widely ignored and instead the symbols are just typed from the namespace nlohmann or, ::nlohmann

Reproduction steps

Try to build with a renamed namespace

Expected vs. actual results

Expected: successful build
Actual: multiple compilation errors where the macro is not respected

Minimal code example

No response

Error messages

No response

Compiler and operating system

any

Library version

any

Validation

@iboB iboB added the kind: bug label Nov 4, 2024
@gregmarr
Copy link
Contributor

gregmarr commented Nov 4, 2024

Which macros are you referring to?

@iboB
Copy link
Author

iboB commented Nov 5, 2024

Which macros are you referring to?

The ones which affect the namespace name (in detail/abi_macros.hpp): JSON_DIAGNOSTICS, NLOHMANN_JSON_NAMESPACE_BEGIN... etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants