Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict compilation flags don't affect the unit tests #37

Open
nathangibson14 opened this issue Nov 4, 2020 · 3 comments
Open

Strict compilation flags don't affect the unit tests #37

nathangibson14 opened this issue Nov 4, 2020 · 3 comments
Assignees

Comments

@nathangibson14
Copy link
Contributor

This is an easy fix, the tests' CMakeLists.txt just need to be updated to use the same variables as the top-level CMakeLists.txt.

@nathangibson14 nathangibson14 self-assigned this Nov 4, 2020
@jlconlin
Copy link
Member

jlconlin commented Nov 4, 2020

Is this something that can be set at the top level and propagated down, or do they have to be re-set at every level?

@nathangibson14
Copy link
Contributor Author

@jlconlin The current repository-level CMakeLists.txt file only allow the tests to be run if the repository is the top-level. I'll likely change that some day, but this was in line with the previous rendition.

Regarding the necessary update, every test's CMakeLists.txt file needs to be updated, not just a simple flag at the top-level. devtools will make doing this quite easy, fortunately.

@jlconlin
Copy link
Member

jlconlin commented Nov 4, 2020

@nathangibson14 What I meant was can the top-level flags be passed to the tests in that repository, not to the dependencies. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants