Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: programs.pqiv only writes config file if both 'settings' and 'extraConfig' is defined #6212

Open
2 tasks done
EmmChriss opened this issue Dec 17, 2024 · 2 comments
Open
2 tasks done
Assignees
Labels
bug triage Issues or feature request that have not been triaged yet

Comments

@EmmChriss
Copy link
Contributor

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

Configuration only gets written if both 'settings' and 'extraConfig' are defined. Desired behaviour is that config gets written when at least one of the two is defined.

Condition at programs.pqiv:68 should be || instead of '&&'.

Maintainer CC

@donovanglover @iynaix

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.6.64, NixOS, 24.11 (Vicuna), 24.11.20241213.314e12b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.10`
 - channels(root): `"nixos-24.11, nixos-hardware"`
 - nixpkgs: `/nix/store/0xbni69flk8380w0apw4h640n37wn1i9-source`
@EmmChriss EmmChriss added bug triage Issues or feature request that have not been triaged yet labels Dec 17, 2024
@donovanglover
Copy link
Contributor

Nice catch! Are you interested in making a PR to fix this?

@EmmChriss
Copy link
Contributor Author

Sure, I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues or feature request that have not been triaged yet
Projects
None yet
Development

No branches or pull requests

5 participants