feat: allow adding custom Vary to static assets header
#2835
Conversation
daniluk4000
changed the title
pi0
changed the title
Vary to static assets header
daniluk4000
changed the title
Vary to static assets headerVary to static assets header
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci
| @@ -310,6 +310,20 @@ export function testNitro( | |||
| expect(data).toMatch("<h1 >Hello JSX!</h1>"); | |||
| }); | |||
|
|
|||
| it.skipIf(ctx.preset.startsWith('cloudflare') || ctx.preset === 'vercel-edge')( | |||
There was a problem hiding this comment.
Is the issue with this two diff in space? (we can normalize headers['vary'] to remove space)
There was a problem hiding this comment.
Here I had something even different with Accept-Encoding not applying at all. I guess it depends on serve static param
There was a problem hiding this comment.
Ah right (when ctx.nitro.options.serveStatic is off we don't even use this)
🔗 Linked issue
Closes #2834
❓ Type of change
📚 Description
Allow to auto-extend Vary header if Accept-Encoding is passed from Nitro.
📝 Checklist