Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: deno server preset use parallel server mechanism #2804

Draft
wants to merge 3 commits into
base: v2
Choose a base branch
from
Draft

wip: deno server preset use parallel server mechanism #2804

wants to merge 3 commits into from

Conversation

yooneskh
Copy link
Contributor

🔗 Linked issue

Fixes #2803

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2803

Changes in this PR at this moment will allow using the parallel server in Deno 2. I have some questions to fully integrate this feature which I would greatly appreciate if you could answer.

  • How can I test run this new preset? Can the playground be used with a specific preset?
  • Deno supports command line arguments to specify port, host, certs and ... for this kind of server. But previously these were given as env vars. What do you propose to do for it?

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@yooneskh yooneskh requested a review from pi0 as a code owner October 19, 2024 20:50
@yooneskh yooneskh changed the title WIP: Deno server preset use parallel server mechanism wip: deno server preset use parallel server mechanism Oct 19, 2024
@pi0 pi0 marked this pull request as draft October 21, 2024 00:49
@pi0
Copy link
Member

pi0 commented Oct 21, 2024

Thank you for PR. I think we might make a deno-cluster preset to have this alternative preset. Running multiple instances have consequences also (for example a migration task should only run in first instance)

@yooneskh
Copy link
Contributor Author

@pi0 That makes sense, thank you.
Are you ok with me duplicating the deno-server preset for this?

@pi0
Copy link
Member

pi0 commented Oct 22, 2024 •
edited
Loading

Sure you can add it seperately (for preset in same file new export + new runtime entry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0 pi0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Use Deno 2 parallel server
2 participants
@yooneskh @pi0