Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default (runtime) Node.js version #2716

Open
1 task done
luc122c opened this issue Sep 6, 2024 · 3 comments · May be fixed by #2794
Open
1 task done

Default (runtime) Node.js version #2716

luc122c opened this issue Sep 6, 2024 · 3 comments · May be fixed by #2794
Assignees
@luc122c
Labels
discussion enhancement New feature or request

Comments

@luc122c
Copy link
Contributor

luc122c commented Sep 6, 2024 •
edited
Loading

Describe the feature

To ensure all deploy providers behave uniformly, we should export a defaultNodeVersion utility to be used within the presets as a fallback.

See this comment for reference.

Additional information

  • Would you be willing to help implement this feature?
@luc122c
Copy link
Contributor Author

luc122c commented Sep 6, 2024 •
edited
Loading

@pi0 Please could you assign this to me 🙏. Also, if you have any additional requirements for this please let me know.

@luc122c
Copy link
Contributor Author

luc122c commented Sep 6, 2024

Related? #2701

@pi0
Copy link
Member

pi0 commented Sep 9, 2024

This is such a nice idea to think about a generic option to configure node runtime version.

However since the range of supported versions across providers differs, i would suggest by first normalizing this for each provider (was, firebase) and then see how we can generalize it.

@pi0 pi0 added enhancement New feature or request discussion and removed pending triage labels Sep 9, 2024
@pi0 pi0 changed the title Internal defaultNodeVersion export Defualt (runtime) Node.js version Sep 9, 2024
@pi0 pi0 assigned pi0 and luc122c and unassigned pi0 Sep 9, 2024
@luc122c luc122c changed the title Defualt (runtime) Node.js version Default (runtime) Node.js version Sep 12, 2024
@luc122c luc122c linked a pull request Oct 13, 2024 that will close this issue
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luc122c luc122c

Labels
discussion enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: default (runtime) Node.js version luc122c/unjs-nitro
2 participants
@pi0 @luc122c