cli: align built-in and plugin rule commit behavior (#85)

Aligning the behavior between built-in rules and rules run via plugins.
Will run all plugins before committing and if warnings occur, commit will get blocked.

Author: nilslice

cmd/protolock/main.go

@@ -84,56 +84,51 @@ func main() {
 		}
 
 	case "commit":
-		r, err := protolock.Commit(*cfg)
-		if err != nil {
-			fmt.Println(err)
-			os.Exit(1)
-		}
-
 		// if force option is false (default), then disallow commit if
 		// there are any warnings encountered by runing a status check.
 		if !*force {
-			report, err := protolock.Status(*cfg)
-			if err != nil {
-				handleReport(report, err)
-			}
-
-			if len(report.Warnings) > 0 {
-				os.Exit(1)
-			}
+			status(cfg)
 		}
 
-		err = saveToLockFile(*cfg, r)
+		r, err := protolock.Commit(*cfg)
 		if err != nil {
 			fmt.Println(err)
 			os.Exit(1)
 		}
 
-	case "status":
-		report, err := protolock.Status(*cfg)
-		if err != protolock.ErrWarningsFound && err != nil {
-			fmt.Println("[protolock]:", err)
+		err = saveToLockFile(*cfg, r)
+		if err != nil {
+			fmt.Println(err)
 			os.Exit(1)
 		}
 
-		// if plugins are provided, attempt to execute each as a exeutable
-		// located in the user's OS executable path as reported by stdlib's
-		// exec.LookPath func
-		if *plugins != "" {
-			report, err = runPlugins(*plugins, report)
-			if err != nil {
-				fmt.Println(err)
-				os.Exit(1)
-			}
-		}
-
-		handleReport(report, err)
+	case "status":
+		status(cfg)
 
 	default:
 		os.Exit(0)
 	}
 }
 
+func status(cfg *protolock.Config) {
+	report, err := protolock.Status(*cfg)
+	if err != protolock.ErrWarningsFound && err != nil {
+		fmt.Println("[protolock]:", err)
+		os.Exit(1)
+	}
+	// if plugins are provided, attempt to execute each as a executable
+	// located in the user's OS executable path as reported by stdlib's
+	// exec.LookPath func
+	if *plugins != "" {
+		report, err = runPlugins(*plugins, report)
+		if err != nil {
+			fmt.Println(err)
+			os.Exit(1)
+		}
+	}
+	handleReport(report, err)
+}
+
 func handleReport(report *protolock.Report, err error) {
 	if len(report.Warnings) > 0 {