Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution guidelines: feedback from @0xn3va #10

Open
nikitastupin opened this issue Mar 16, 2023 · 0 comments
Open

contribution guidelines: feedback from @0xn3va #10

nikitastupin opened this issue Mar 16, 2023 · 0 comments
Assignees

Comments

@nikitastupin
Copy link
Owner

The feedback was originally given in #8 Copy-pasting it here for further consideration:

I'd like to add that I've read your contribution guide at https://github.com/nikitastupin/orgs-data/blob/main/CONTRIBUTING.md but it looks too complicated to contribute changes :) So, I tried to contribute in this way, if you do not like it, feel free to decline this PR, I'm completely OK with that. Thanks!

The contribution guide itself is easy to use, but proposing multiple changes through Google forms is inconvenient. From my point of view, it would be possible to add an option through opening a PR and offer a general approach to opening it, for example, an author should follow the defined notation and pre-process final tables before opening a PR (sort them, replace spaces with tabs, and etc.). If this path is acceptable, it would be awesome to have such option in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant