Skip to content

Commit 253d8e8

Browse files
committed
Docs grammar fixes
joined split infinitives, and relocated adverbs appropriately.
1 parent a85b643 commit 253d8e8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+134
-124
lines changed

docs/changes_0.x.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ Version 0.30.0 (2016-01-23)
88

99
Compatibility notes:
1010

11-
- you may need to use -v (or --info) more often to actually see output emitted
12-
at INFO log level (because it is suppressed at the default WARNING log level).
11+
- The new default logging level is WARNING. Previously, it was INFO, which was
12+
more verbose. Use -v (or --info) to show once again log level INFO messages.
1313
See the "general" section in the usage docs.
1414
- for borg create, you need --list (additionally to -v) to see the long file
1515
list (was needed so you can have e.g. --stats alone without the long list)

docs/changes_1.x.rst

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,7 @@ Other changes:
776776
- docs:
777777

778778
- improve description of path variables
779-
- document how to completely delete data, #2929
779+
- document how to delete data completely, #2929
780780
- add FAQ about Borg config dir, #4941
781781
- add docs about errors not printed as JSON, #4073
782782
- update usage_general.rst.inc
@@ -2149,7 +2149,7 @@ New features:
21492149
- mount: added exclusion group options and paths, #2138
21502150

21512151
Reused some code to support similar options/paths as borg extract offers -
2152-
making good use of these to only mount a smaller subset of dirs/files can
2152+
making good use of these to mount only a smaller subset of dirs/files can
21532153
speed up mounting a lot and also will consume way less memory.
21542154

21552155
borg mount [options] repo_or_archive mountpoint path [paths...]
@@ -3078,7 +3078,7 @@ New features:
30783078
which includes the SHA1 and SHA2 family as well as MD5
30793079
- borg prune:
30803080

3081-
- to better visualize the "thinning out", we now list all archives in
3081+
- to visualize the "thinning out" better, we now list all archives in
30823082
reverse time order. rephrase and reorder help text.
30833083
- implement --keep-last N via --keep-secondly N, also --keep-minutely.
30843084
assuming that there is not more than 1 backup archive made in 1s,
@@ -3505,8 +3505,18 @@ Security fixes:
35053505

35063506
CVE-2016-10099 was assigned to this vulnerability.
35073507
- borg check: When rebuilding the manifest (which should only be needed very rarely)
3508-
duplicate archive names would be handled on a "first come first serve" basis, allowing
3509-
an attacker to apparently replace archives.
3508+
duplicate archive names would be handled on a "first come first serve" basis,
3509+
potentially opening an attack vector to replace archives.
3510+
3511+
Example: were there 2 archives named "foo" in a repo (which can not happen
3512+
under normal circumstances, because borg checks if the name is already used)
3513+
and a "borg check" recreated a (previously lost) manifest, the first of the
3514+
archives it encountered would be in the manifest. The second archive is also
3515+
still in the repo, but not referenced in the manifest, in this case. If the
3516+
second archive is the "correct" one (and was previously referenced from the
3517+
manifest), it looks like it got replaced by the first one. In the manifest,
3518+
it actually got replaced. Both remain in the repo but the "correct" one is no
3519+
longer accessible via normal means - the manifest.
35103520

35113521
CVE-2016-10100 was assigned to this vulnerability.
35123522

@@ -4234,20 +4244,20 @@ Compatibility notes:
42344244
changed file and in the worst case (e.g. if your files cache was lost / is
42354245
not used) by the size of every file (minus any compression you might use).
42364246

4237-
in case you want to immediately see a much lower resource usage (RAM / disk)
4247+
in case you want to see a much lower resource usage immediately (RAM / disk)
42384248
for chunks management, it might be better to start with a new repo than
4239-
continuing in the existing repo (with an existing repo, you'ld have to wait
4240-
until all archives with small chunks got pruned to see a lower resource
4249+
to continue in the existing repo (with an existing repo, you have to wait
4250+
until all archives with small chunks get pruned to see a lower resource
42414251
usage).
42424252

42434253
if you used the old --chunker-params default value (or if you did not use
4244-
--chunker-params option at all) and you'ld like to continue using small
4254+
--chunker-params option at all) and you'd like to continue using small
42454255
chunks (and you accept the huge resource usage that comes with that), just
4246-
explicitly use borg create --chunker-params=10,23,16,4095.
4256+
use explicitly borg create --chunker-params=10,23,16,4095.
42474257
- archive timestamps: the 'time' timestamp now refers to archive creation
42484258
start time (was: end time), the new 'time_end' timestamp refers to archive
4249-
creation end time. This might affect prune if your backups take rather long.
4250-
if you give a timestamp via cli this is stored into 'time', therefore it now
4259+
creation end time. This might affect prune if your backups take a long time.
4260+
if you give a timestamp via cli, this is stored into 'time'. therefore it now
42514261
needs to mean archive creation start time.
42524262

42534263
New features:
@@ -4289,8 +4299,8 @@ Bug fixes:
42894299

42904300
Other changes:
42914301

4292-
- it is now possible to use "pip install borgbackup[fuse]" to automatically
4293-
install the llfuse dependency using the correct version requirement
4302+
- it is now possible to use "pip install borgbackup[fuse]" to
4303+
install the llfuse dependency automatically, using the correct version requirement
42944304
for it. you still need to care about having installed the FUSE / build
42954305
related OS package first, though, so that building llfuse can succeed.
42964306
- Vagrant: drop Ubuntu Precise (12.04) - does not have Python >= 3.4

docs/deployment/automated-local.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,13 @@ after creating the backup. Rename the file to something else (e.g. ``/etc/backup
168168
when you want to do something with the drive after creating backups (e.g running check).
169169

170170
Create the ``/etc/backups/backup-suspend`` file if the machine should suspend after completing
171-
the backup. Don't forget to physically disconnect the device before resuming,
171+
the backup. Don't forget to disconnect the device physically before resuming,
172172
otherwise you'll enter a cycle. You can also add an option to power down instead.
173173

174174
Create an empty ``/etc/backups/backup.disks`` file, you'll register your backup drives
175175
there.
176176

177-
The last part is to actually enable the udev rules and services:
177+
The last part is actually to enable the udev rules and services:
178178

179179
.. code-block:: bash
180180

docs/deployment/hosting-repositories.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
Hosting repositories
66
====================
77

8-
This sections shows how to securely provide repository storage for users.
8+
This sections shows how to provide repository storage securely for users.
99
Optionally, each user can have a storage quota.
1010

1111
Repositories are accessed through SSH. Each user of the service should

docs/deployment/image-backup.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Because the partitions were zeroed in place, restoration is only one command::
7777
borg extract --stdout repo::hostname-disk | dd of=$DISK
7878

7979
.. note:: The "traditional" way to zero out space on a partition, especially one already
80-
mounted, is to simply ``dd`` from ``/dev/zero`` to a temporary file and delete
80+
mounted, is simply to ``dd`` from ``/dev/zero`` to a temporary file and delete
8181
it. This is ill-advised for the reasons mentioned in the ``zerofree`` man page:
8282

8383
- it is slow

docs/deployment/pull-backup.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ Now we can run
161161

162162
borg extract /borgrepo::archive PATH
163163

164-
to partially restore whatever we like. Finally, do the clean-up:
164+
to restore whatever we like partially. Finally, do the clean-up:
165165

166166
::
167167

@@ -209,8 +209,8 @@ socat
209209
=====
210210

211211
In this setup a SSH connection from the backup server to the client is
212-
established that uses SSH reverse port forwarding to transparently
213-
tunnel data between UNIX domain sockets on the client and server and the socat
212+
established that uses SSH reverse port forwarding to tunnel data
213+
transparently between UNIX domain sockets on the client and server and the socat
214214
tool to connect these with the borg client and server processes, respectively.
215215

216216
The program socat has to be available on the backup server and on the client
@@ -277,7 +277,7 @@ forwarding can do this for us::
277277

278278
Warning: remote port forwarding failed for listen path /run/borg/reponame.sock
279279

280-
When you are done, you have to manually remove the socket file, otherwise
280+
When you are done, you have to remove the socket file manually, otherwise
281281
you may see an error like this when trying to execute borg commands::
282282

283283
Remote: YYYY/MM/DD HH:MM:SS socat[XXX] E connect(5, AF=1 "/run/borg/reponame.sock", 13): Connection refused
@@ -417,7 +417,7 @@ Parentheses are not needed when using a dedicated bash process.
417417

418418
*ssh://borgs@borg-server/~/repo* refers to the repository *repo* within borgs's home directory on *borg-server*.
419419

420-
*StrictHostKeyChecking=no* is used to automatically add host keys to *~/.ssh/known_hosts* without user intervention.
420+
*StrictHostKeyChecking=no* is used to add host keys automatically to *~/.ssh/known_hosts* without user intervention.
421421

422422
``kill "${SSH_AGENT_PID}"``
423423

docs/faq.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ run into this by yourself by restoring an older copy of your repository.
8686
"attack": maybe an attacker has replaced your repo by an older copy, trying to
8787
trick you into AES counter reuse, trying to break your repo encryption.
8888

89-
If you'ld decide to ignore this and accept unsafe operation for this repository,
89+
If you decide to ignore this and accept unsafe operation for this repository,
9090
you could delete the manifest-timestamp and the local cache:
9191

9292
::
@@ -159,7 +159,7 @@ so that checkpoints even work while a big file is being processed.
159159
They are named ``<filename>.borg_part_<N>`` and all operations usually ignore
160160
these files, but you can make them considered by giving the option
161161
``--consider-part-files``. You usually only need that option if you are
162-
really desperate (e.g. if you have no completed backup of that file and you'ld
162+
really desperate (e.g. if you have no completed backup of that file and you'd
163163
rather get a partial file extracted than nothing). You do **not** want to give
164164
that option under any normal circumstances.
165165

@@ -342,7 +342,7 @@ That's **45** orders of magnitude more probable than the SHA-256 collision. Brie
342342
if you find SHA-256 collisions scary then your priorities are wrong. This example was grabbed from
343343
`this SO answer <https://stackoverflow.com/a/4014407/13359375>`_, it's great honestly.
344344

345-
Still, the real question is if Borg tries not to make this happen?
345+
Still, the real question is whether Borg tries not to make this happen?
346346

347347
Well... previously it did not check anything until there was a feature added which saves the size
348348
of the chunks too, so the size of the chunks is compared to the size that you got with the
@@ -467,7 +467,7 @@ Setting ``BORG_PASSPHRASE``
467467
user
468468
<https://security.stackexchange.com/questions/14000/environment-variable-accessibility-in-linux/14009#14009>`_.
469469

470-
Using ``BORG_PASSCOMMAND`` with a properly permissioned file
470+
Using ``BORG_PASSCOMMAND`` with a file of proper permissions
471471
Another option is to create a file with a password in it in your home
472472
directory and use permissions to keep anyone else from reading it. For
473473
example, first create a key::
@@ -524,7 +524,7 @@ Using ``BORG_PASSCOMMAND`` with GNOME Keyring
524524

525525
export BORG_PASSCOMMAND="secret-tool lookup borg-repository repo-name"
526526

527-
.. note:: For this to automatically unlock the keychain it must be run
527+
.. note:: For this to unlock the keychain automatically it must be run
528528
in the ``dbus`` session of an unlocked terminal; for example, running a backup
529529
script as a ``cron`` job might not work unless you also ``export DISPLAY=:0``
530530
so ``secret-tool`` can pick up your open session. `It gets even more complicated`__
@@ -573,7 +573,7 @@ C to delete all backups residing on S.
573573

574574
These are your options to protect against that:
575575

576-
- Do not allow to permanently delete data from the repo, see :ref:`append_only_mode`.
576+
- Do not allow to delete data permanently from the repo, see :ref:`append_only_mode`.
577577
- Use a pull-mode setup using ``ssh -R``, see :ref:`pull_backup` for more information.
578578
- Mount C's filesystem on another machine and then create a backup of it.
579579
- Do not give C filesystem-level access to S.
@@ -853,7 +853,7 @@ Then you do the backup and look at the log output:
853853
The metadata values used in this comparison are determined by the ``--files-cache`` option
854854
and could be e.g. size, ctime and inode number (see the ``borg create`` docs for more
855855
details and potential issues).
856-
You can use the ``stat`` command on files to manually look at fs metadata to debug if
856+
You can use the ``stat`` command on files to look at fs metadata manually to debug if
857857
there is any unexpected change triggering the ``M`` status.
858858
Also, the ``--debug-topic=files_cache`` option of ``borg create`` provides a lot of debug
859859
output helping to analyse why the files cache does not give its expected high performance.

docs/installation.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ fail if /tmp has not enough free space or is mounted with the ``noexec``
134134
option. You can change the temporary directory by setting the ``TEMP``
135135
environment variable before running Borg.
136136

137-
If a new version is released, you will have to manually download it and replace
137+
If a new version is released, you will have to download it manually and replace
138138
the old version using the same steps as shown above.
139139

140140
.. _pyinstaller: http://www.pyinstaller.org
@@ -331,7 +331,7 @@ optional, but recommended except for the most simple use cases.
331331
If you install into a virtual environment, you need to **activate** it
332332
first (``source borg-env/bin/activate``), before running ``borg``.
333333
Alternatively, symlink ``borg-env/bin/borg`` into some directory that is in
334-
your ``PATH`` so you can just run ``borg``.
334+
your ``PATH`` so you can run ``borg``.
335335

336336
This will use ``pip`` to install the latest release from PyPi::
337337

docs/internals.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ metadata, using :ref:`chunks` created by the chunker using the
2222
Buzhash_ algorithm ("buzhash" chunker) or a simpler fixed blocksize
2323
algorithm ("fixed" chunker).
2424

25-
To actually perform the repository-wide deduplication, a hash of each
25+
To perform the repository-wide deduplication, a hash of each
2626
chunk is checked against the :ref:`chunks cache <cache>`, which is a
2727
hash-table of all chunks that already exist.
2828

docs/internals/data-structures.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,8 @@ An object (the payload part of a segment file log entry) must be like:
157157

158158
- compressed data (with an optional all-zero-bytes obfuscation trailer)
159159

160-
This new, more complex repo v2 object format was implemented to be able to efficiently
161-
query the metadata without having to read, transfer and decrypt the (usually much bigger)
160+
This new, more complex repo v2 object format was implemented to be able to query the
161+
metadata efficiently without having to read, transfer and decrypt the (usually much bigger)
162162
data part.
163163

164164
The metadata is encrypted not to disclose potentially sensitive information that could be

0 commit comments

Comments
 (0)