Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Deactivate Pod card from being dismissed with a sideways pull #389

Open
marionbarker opened this issue Aug 19, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request in-progress

Comments

@marionbarker
Copy link
Contributor

Is your feature request related to a problem? Please describe.

A pod is deactivated by dragging a slider across the screen. It is really easy to miss where your finger is placed and drag the whole card - which dismisses that screen.

Describe the solution you'd like

Do not allow the screen to be dismissed by dragging sideways.

Describe alternatives you've considered

N/A

Additional context

The Insert Cannula screen has a similar slider and does not get dismissed accidentally.

Technical Details

I asked for help, received some suggestions, compared Insert and Deactivate code side by side. Adding one line to Deactivate solves the issue. I will prepare the PR for OmniBLE and OmniKit so we can thoroughly test this.

User Impact

I run into this problem a lot with my test phones and several people have complained about it, but I did not collect statistics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress
Projects
Status: No status
Development

No branches or pull requests

3 participants