We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADLError
Firstly, I understand there has not been activity on this repo in several years. Still, hoping this can be addressed.
Importing ADLManager like so works, but PyCharm (and probably other IDEs) complain about "too broad exception" and for good reason.
try: from pyadl import ADLManager except Exception: # cannot import `ADLError` from `pyadl.pyadl` pass # no amd gpus found else: ...
Ideally it would say except ADLError:, unfortunately it is also not possible to import ADLError.
except ADLError:
I believe that it should just throw the original OSError so that it can be handled more properly by users of the library.
OSError
pyadl/pyadl/pyadl.py
Line 28 in b367e04
I'm happy to create a PR if such a change would be accepted. Please let me know. Thanks!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Firstly, I understand there has not been activity on this repo in several years. Still, hoping this can be addressed.
Importing ADLManager like so works, but PyCharm (and probably other IDEs) complain about "too broad exception" and for good reason.
Ideally it would say
except ADLError:
, unfortunately it is also not possible to importADLError
.I believe that it should just throw the original
OSError
so that it can be handled more properly by users of the library.pyadl/pyadl/pyadl.py
Line 28 in b367e04
I'm happy to create a PR if such a change would be accepted. Please let me know. Thanks!
The text was updated successfully, but these errors were encountered: