Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect counters if many pull requests #10

Open
nicokosi opened this issue Jan 19, 2017 · 3 comments
Open

Incorrect counters if many pull requests #10

nicokosi opened this issue Jan 19, 2017 · 3 comments
Labels

Comments

@nicokosi
Copy link
Owner

nicokosi commented Jan 19, 2017

For example :

lein run --organization docker --repository docker --token $token --since-weeks 4                                         
pull requests for docker/docker ->
	since 4 week(s):
		18 opened / 43 commented / 16 closed
		opened per author: {"samattridge" 2, "aaronlehmann" 2, "yongtang" 1, "wojas" 1, "vieux" 1, "vdemeester" 1, "twang2218" 1, "pmelopereira" 1, "panmanphil" 1, "nishanttotla" 1, "krasi-georgiev" 1, "kklemmicknvidia" 1, "jhowardmsft" 1, "eZanmoto" 1, "alexandrevicenzi" 1, "albers" 1}
		commented per author: {"aaronlehmann" 9, "thaJeztah" 6, "johnstep" 5, "cpuguy83" 5, "stevvooe" 3, "dnephin" 3, "vdemeester" 2, "tianon" 2, "runcom" 2, "vikstrous" 1, "tophj-ibm" 1, "tonistiigi" 1, "ehazlett" 1, "cyli" 1, "allencloud" 1}
		closed per author: {"thaJeztah" 2, "cpuguy83" 1, "allencloud" 1}

But more pull requests have been created/closed (and probably commented), as seen via Monthly Pulse:

http https://github.com/docker/docker/pulse/monthly | grep -B 2 "Merged Pull Requests\|Proposed Pull Requests"
            274
          </span>
          Merged Pull Requests
--
            91
          </span>
          Proposed Pull Requests
@nicokosi
Copy link
Owner Author

GitHub REST API for events is currently used and has these limitations:

Events support pagination, however the per_page option is unsupported. The fixed page size is 30 items. Fetching up to ten pages is supported, for a total of 300 events.

Only events created within the past 90 days will be included in timelines. Events older than 90 days will not be included (even if the total number of events in the timeline is less than 300).

May GitHub GraphQL API usage fix these limitations?

@nicokosi nicokosi changed the title Incorrect counters for numerous results Incorrect counters if many pull requests Jan 19, 2017
@nicokosi nicokosi added the bug label Jan 28, 2017
@nicokosi
Copy link
Owner Author

See nicokosi/pullpito#24 (comment) for Graphql requests.

@nicokosi
Copy link
Owner Author

May the library lacinia be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant