WIP Unnest search param #81
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also fixes usage of onInput TODO * Update ember-try config (ember-power-select only works on Ember 3.11+) * Fix tests failures related to ember-infinity
* Refactor to glimmer components * Min Ember.js version is 3.13 instead of 3.12 because tracked properties are used
Also fix/update docs on global configuration.
|
I'm thinking as we're doing a major release anyway if maybe we should change the behaviour to allow omitting the searchProperty (and then it'd only use the searchKey)? Might make more sense instead of introducing more options. |
|
Sure, sounds like a cleaner approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
nestSearchParamargument, to be able to support backends which require search params without any nesting, such as&search=<TERM>. The current behaviour (&searchProperty[searchKey]=<TERM>) remains the default choice.Fixes #80.
This is based on #78 and will be rebased on master once the former is merged.