Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change lexical alignment default to 1-grams #26

Open
fusaroli opened this issue May 16, 2018 · 1 comment
Open

Change lexical alignment default to 1-grams #26

fusaroli opened this issue May 16, 2018 · 1 comment

Comments

@fusaroli
Copy link
Collaborator

No article in the current literature uses n-grams above 1 for lexical alignment. It'd make sense to change the default to 1.

@fusaroli
Copy link
Collaborator Author

The fix seems pretty straightforward: in the calculate alignment.py, function LexicalPOSAlignment, the line
for ngram in range(2,maxngram+1):

should become

for ngram in range(1,maxngram+1):

This however has the potential drawback of providing the user with an additional meaningless syntactic alignment of 1-grams.
No biggie for me, but if we want to avoid that, it could be solved by not passing along the penn_tok1 and penn_lem1 (including the stan stuff).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants