Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: measure text function taking a pointer is redundant #74

Open
mikejsavage opened this issue Dec 21, 2024 · 2 comments
Open

Minor: measure text function taking a pointer is redundant #74

mikejsavage opened this issue Dec 21, 2024 · 2 comments

Comments

@mikejsavage
Copy link
Contributor

Clay's text measuring callback is defined to take a pointer to Clay_String, which seems redundant because Clay_String is already a pointer.

I may be wrong but it looks like the rest of the codebase takes Clay_String directly, besides some things that are downstream of MeasureText.

@nicbarker
Copy link
Owner

Yes, I'd say you're probably right. It will be a breaking change at this point though, so I'll have to do it soon if it were to change 😅

@Muzz
Copy link

Muzz commented Dec 22, 2024

Imo it's a new library, you should just make breaking changes for the first few versions, and focus on nailing all this stuff in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants