Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @typescript-eslint/eslint-plugin @typescript-eslint/parser #150

Open
TrevorKarjanis opened this issue Jul 24, 2024 · 2 comments
Open
Assignees

Comments

@TrevorKarjanis
Copy link
Collaborator

After upgrading to Angular 17, the following warning is received when running the linter.

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0
YOUR TYPESCRIPT VERSION: 5.4.5
Please only submit bug reports when using the officially supported version.

This is because @typescript-eslint/eslint-plugin @typescript-eslint/parser are incompatible with [email protected]. This is not an npm dependency. It is defined at runtime in @typescript-eslint/typescript-estree.

These packages, version ^5.62.0, are peer dependencies of @ni/eslint-config-typescript, so upgrading them requires forcing the install. @typescript-eslint/[email protected] supports <5.5, so a minimal upgrade of @typescript-eslint/[email protected] @typescript-eslint/[email protected] would be required.

Have we considered upgrading them, or why have they not been upgraded?

@rajsite
Copy link
Member

rajsite commented Jul 25, 2024

Have we considered upgrading them, or why have they not been upgraded?

No specific reason I'm aware. Don't have a rennovate integration so would be manual. Looking at the getting started today they don't even pull from the scoped packages like we are which is interesting: https://typescript-eslint.io/getting-started/

Edit: Ahh we are on the "legacy" eslint configuration: https://typescript-eslint.io/getting-started/legacy-eslint-setup

@jattasNI
Copy link
Collaborator

We agreed we should fix this soon. May need to do a bit of testing to ensure the new packages don't change the behavior of any rules in unexpected ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants