Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Airbnb ruleset #116

Open
jattasNI opened this issue Dec 1, 2022 · 0 comments
Open

Remove dependency on Airbnb ruleset #116

jattasNI opened this issue Dec 1, 2022 · 0 comments
Assignees
Labels
needs-proposal Needs investigation and a proposal to implement

Comments

@jattasNI
Copy link
Collaborator

jattasNI commented Dec 1, 2022

We think it would be a good idea to remove the dependency on the Airbnb ruleset since it makes it more complicated to understand how rules are configured in this repo. There doesn't appear to be much maintenance happening so we feel reasonably convinced that this won't cause us extra work.

We would do this by copying their configurations into our repo and unwinding our overrides. We could also remove configurations that don't apply to NI code like React rules.

We'll need to decide whether to keep their file organization or concatenate them.

@jattasNI jattasNI added the triage label Dec 1, 2022
@jattasNI jattasNI removed the triage label Jan 12, 2023
@jattasNI jattasNI added the needs-proposal Needs investigation and a proposal to implement label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-proposal Needs investigation and a proposal to implement
Projects
None yet
Development

No branches or pull requests

2 participants