Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Dependency Support for angular v9 & v10 #497

Open
jcheenatcode opened this issue Jul 2, 2020 · 1 comment
Open

Peer Dependency Support for angular v9 & v10 #497

jcheenatcode opened this issue Jul 2, 2020 · 1 comment

Comments

@jcheenatcode
Copy link

jcheenatcode commented Jul 2, 2020

The peer dependencies for "@ngxs-labs/immer-adapter": "^3.0.5" from npm, seems to be having a different peer dependency, than what's in master.

"peerDependencies": {
    "@angular/core": "^8.0.2",
    "@ngxs/store": "^3.4.0",
    "immer": "^3.1.2"
  }

What would be required to publish a newer version of this library?

  • is it something like a manual PR that could be created & submitted? (what would be needed to do?)
  • or is it something like an automated process & which is broken, because of which its not getting published to npm?

Or, Should we not use this library at all and just use the immer library directly as stated here

@ckorherr
Copy link

I get the following warning with Angular 11:

npm WARN @ngxs-labs/[email protected] requires a peer of @angular/core@^8.0.2 but none is installed. You must install peer dependencies yourself.
npm WARN @ngxs-labs/[email protected] requires a peer of immer@^3.1.2 but none is installed. You must install peer dependencies yourself.      

Is this package still supported and will there be an update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants