Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ngrx/effects: Update examples to standalone APIs #4468

Open
2 tasks
markostanimirovic opened this issue Jul 30, 2024 · 4 comments · May be fixed by #4522
Open
2 tasks

@ngrx/effects: Update examples to standalone APIs #4468

markostanimirovic opened this issue Jul 30, 2024 · 4 comments · May be fixed by #4522
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Project: Effects

Comments

@markostanimirovic
Copy link
Member

Information

Standalone APIs have been stable since Angular v16, and we should update the @ngrx/effects documentation to use standalone APIs by default, and reference previous versions of the docs for module-based apps.

Documentation page

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@markostanimirovic markostanimirovic mentioned this issue Jul 30, 2024
Open
2 tasks
@AdrianRomanski
Copy link

I can give It a try :)

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Aug 7, 2024
@markostanimirovic
Copy link
Member Author

@AdrianRomanski check this PR: #4486 for more info on what needs to be done

@markostanimirovic
Copy link
Member Author

Hi @AdrianRomanski,

Are you still interested in working on this issue? If not, let us know so someone else can take it.

@AdrianRomanski
Copy link

@markostanimirovic hello, Yes sorry i somehow Lost your first mention.
I will start working on It at The weekend

@timdeschryver timdeschryver linked a pull request Sep 11, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Project: Effects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(effects): update examples to standalone api AdrianRomanski/platform
3 participants
@markostanimirovic @timdeschryver @AdrianRomanski