From b916e8c5af4693ab6b464cfa2784a2459b0e8c3f Mon Sep 17 00:00:00 2001
From: Kate Osborn <k.osborn@f5.com>
Date: Mon, 27 Jan 2025 15:31:00 -0700
Subject: [PATCH] Add more test coverage

---
 .../state/dataplane/configuration_test.go     | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/internal/mode/static/state/dataplane/configuration_test.go b/internal/mode/static/state/dataplane/configuration_test.go
index 21c7bf3a8b..3c61ed0ff3 100644
--- a/internal/mode/static/state/dataplane/configuration_test.go
+++ b/internal/mode/static/state/dataplane/configuration_test.go
@@ -3256,6 +3256,11 @@ func TestBuildTelemetry(t *testing.T) {
 		msg          string
 		expTelemetry Telemetry
 	}{
+		{
+			g:            &graph.Graph{},
+			expTelemetry: Telemetry{},
+			msg:          "nil Gateway",
+		},
 		{
 			g: &graph.Graph{
 				Gateway: &graph.Gateway{
@@ -3274,6 +3279,52 @@ func TestBuildTelemetry(t *testing.T) {
 			expTelemetry: Telemetry{},
 			msg:          "No telemetry configured",
 		},
+		{
+			g: &graph.Graph{
+				Gateway: &graph.Gateway{
+					EffectiveNginxProxy: &graph.EffectiveNginxProxy{
+						Telemetry: &ngfAPIv1alpha2.Telemetry{
+							Exporter: &ngfAPIv1alpha2.TelemetryExporter{
+								Endpoint: helpers.GetPointer("my-otel.svc:4563"),
+							},
+							DisabledFeatures: []ngfAPIv1alpha2.DisableTelemetryFeature{
+								ngfAPIv1alpha2.DisableTracing,
+							},
+						},
+					},
+				},
+			},
+			expTelemetry: Telemetry{},
+			msg:          "Telemetry disabled explicitly",
+		},
+		{
+			g: &graph.Graph{
+				Gateway: &graph.Gateway{
+					EffectiveNginxProxy: &graph.EffectiveNginxProxy{
+						Telemetry: &ngfAPIv1alpha2.Telemetry{
+							Exporter: nil,
+						},
+					},
+				},
+			},
+			expTelemetry: Telemetry{},
+			msg:          "Telemetry disabled implicitly (nil exporter)",
+		},
+		{
+			g: &graph.Graph{
+				Gateway: &graph.Gateway{
+					EffectiveNginxProxy: &graph.EffectiveNginxProxy{
+						Telemetry: &ngfAPIv1alpha2.Telemetry{
+							Exporter: &ngfAPIv1alpha2.TelemetryExporter{
+								Endpoint: nil,
+							},
+						},
+					},
+				},
+			},
+			expTelemetry: Telemetry{},
+			msg:          "Telemetry disabled implicitly (nil exporter endpoint)",
+		},
 		{
 			g: &graph.Graph{
 				Gateway: &graph.Gateway{