Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nextclade extension to public builds #197

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Nov 18, 2024

Description of proposed changes

Adds Nextclade extension with "subclade" annotation to Auspice config for all public builds, allowing users to get these subclade annotations from Nextclade for any public tree.

To test this functionality, I added subclade annotations to the CI build and confirmed that the extension worked as expected by uploading the CI Auspice JSON to the staging server before and after I included the extension in the JSON.

Checklist

  • Checks pass
  • Confirm that Nextclade annotations from CI build on staging show subclade

Adds Nextclade extension with "subclade" annotation to Auspice config
for all public builds, allowing users to get these subclade annotations
from Nextclade for any public tree.

To test this functionality, I added subclade annotations to the CI build
and confirmed that the extension worked as expected by uploading the CI
Auspice JSON to the staging server before and after I included the
extension in the JSON.
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering what happens if you include the extension in dataset without subclade labels and looks like you just get a blank column which seems fine.

@huddlej huddlej merged commit 20c935b into master Nov 19, 2024
3 checks passed
@huddlej huddlej deleted the add-nextclade-extension branch November 19, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants