Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Edit on Github goes to 404 for transcluded pages #152

Open
corneliusroemer opened this issue Feb 22, 2023 · 1 comment
Open

BUG: Edit on Github goes to 404 for transcluded pages #152

corneliusroemer opened this issue Feb 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@corneliusroemer
Copy link
Member

corneliusroemer commented Feb 22, 2023

When clicking the Edit on Github button at the top right on the beast guide page: https://docs.nextstrain.org/en/latest/guides/bioinformatics/import-beast.html, one ends up with a 404 Github error: https://github.com/nextstrain/docs.nextstrain.org/blob/master/src/guides/bioinformatics/import-beast.md

image

image

The page actually lives here: https://github.com/nextstrain/augur/blob/f4e46fba552297577dcbbc0bd3644639452a1591/docs/faq/import-beast.md?plain=1#L1

There are probably a few other doc pages with the same bug, possibly all those here:

docs = {
f'{auspice_url}narratives/create-pdf.md': 'guides/communicate/create-pdf.md',
f'{auspice_url}narratives/introduction.md': 'guides/communicate/narratives-intro.md',
f'{augur_url}usage/augur_snakemake.md': 'guides/bioinformatics/augur_snakemake.md',
f'{augur_url}faq/translate_ref.md': 'guides/bioinformatics/translate_ref.md',
f'{augur_url}faq/import-beast.md': 'guides/bioinformatics/import-beast.md',
f'{augur_url}faq/colors.md': 'guides/bioinformatics/colors.md',
f'{augur_url}faq/lat_longs.md': 'guides/bioinformatics/lat_longs.md',
f'{augur_url}faq/vcf_input.md': 'guides/bioinformatics/vcf_input.md',
f'{augur_url}faq/fasta_input.md': 'guides/bioinformatics/fasta_input.md',
f'{augur_url}faq/seq_traits.md': 'guides/bioinformatics/seq_traits.md',
f'{augur_url}examples/examples.rst': 'guides/bioinformatics/examples.rst',

@corneliusroemer corneliusroemer added the bug Something isn't working label Feb 22, 2023
@tsibley tsibley changed the title BUG: Edit on Github goes to 404 for beast guide BUG: Edit on Github goes to 404 for transcluded pages Mar 1, 2023
@victorlin victorlin moved this from New to Backlog in Nextstrain planning (archived) Mar 8, 2023
@victorlin
Copy link
Member

I'm not sure if there is an easy fix here since the docs fetching is inherently hacky. The proper solution would be to replace that implementation: #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

2 participants