-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very bright images make NC icons undiscernable / unusable #101
Comments
This is not an easy one, and we had issues with contrast in the past. I generally consider this 'working as intended', since we cant check the image before display, to verify it 'looks good'. However, i have added some featues in the dev-branch that may help. You will eventually be able to apply a tint to each image, which will give you the ability to generally increase contrast with any image that may be loaded |
Thanks for the quick reply |
You can already disable the background image for the header in the settings under theming |
It's already unticked. Here is the behavior :
EDIT |
Okay |
I have an idea to fix this permanently |
Cool ! Just a comment on the css trick from #header { I noticed that in combination with splash :
Just a remark ! |
I have this issues too. I would love the extension to set a consistent semi-transparent header background. I think it would be a nice polish features as opposed to the bight colored bar from the rest of the nextcloud theme. |
It would be great to have this tint functionality only behind the icon line and not for the whole image |
A workaround I'm using, added via the Custom CSS app: #header > div {
background: rgba(0, 0, 0, 0.33);
} This CSS targets the header's inner |
@LaXiS96 I didn't know about the custom CSS plugin, that's a great workaround! I tweaked the CSS a little bit, and made the header bar style match up with Nextcloud's dark theme: body > #header {
background: rgba(23, 23, 23, 0.8) !important;
backdrop-filter: blur(25px);
}
.content, #content {
margin-top: 55px !important;
} The margin is there so you don't end up with ugly corners like this: It would be great to see this built in to the app, or at least an option in the settings. But in the meantime, the Custom CSS app provides a good workaround. |
use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!
Describe the bug:
When a image with very bright light colors is randomly picked up, there is no contrast with NC icons which make it practically unusable (need to reload the page to have more contrast).
To Reproduce:
Steps to reproduce the behavior:
Refresh page until a very light image is loaded
Or.. look at the screenshots provided
Expected behavior:
There should be a shadow or dark line around NC icons.
Alternatively, header should be opaque.
Server:
The text was updated successfully, but these errors were encountered: