Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming PHP-FPM changes for httpd ProxyPass and ProxyPassMatch handling. #50738

Open
bukka opened this issue Feb 8, 2025 · 0 comments
Open
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap technical debt

Comments

@bukka
Copy link

bukka commented Feb 8, 2025

Apology for opening this nextcloud possible non issue but wanted to double check with you some changes that I'm adding to php-fpm in terms of handling PATH_INFO from ProxyPass and ProxyPassMatch which is quite inconsistent. The issue with those is that they send URL encoded path info and script file name. I applied the PATH_INFO fix in php/php-src#17643 which just got merged and should be part of 8.3.18. It will basically provide the PATH_INFO decode. This should be quite safe but wanted to check with you in case you do some special handling for that. Another one which would decode the whole script path will be probably just for master: php/php-src#17645 . But if you can see any issue with that, I could maybe add some switch for it.

This is mainly created here because there were some issues reported here. This in relation to past bugs #37852 and #40943 create by @mrAceT .

Feel free to close this it if you don't see any potential issues for nextcloud after this gets implemented.

@solracsf solracsf added 0. Needs triage Pending check for reproducibility or if it fits our roadmap technical debt labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap technical debt
Projects
None yet
Development

No branches or pull requests

2 participants