Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated share is listed in internal shares #50656

Open
juliusknorr opened this issue Feb 5, 2025 · 2 comments
Open

Federated share is listed in internal shares #50656

juliusknorr opened this issue Feb 5, 2025 · 2 comments

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Feb 5, 2025

Steps to reproduce

  1. Create a new federated share in the "External shares" section

Actual behaviour

The share is listed in the list of internal shares

Expected behaviour

I would expect it in the same section where I enter it (external shares). Thinking about it there may be arguments for global scale to rather put the federated sharing to internal shares (but only for that).

Image

cc @nfebe @marcoambrosini

@juliusknorr juliusknorr added bug 1. to develop Accepted and waiting to be taken care of feature: sharing 31-feedback labels Feb 5, 2025
@juliusknorr
Copy link
Member Author

A few polishing suggestions that also come to my mind when looking at the screenshot

  • Input labels have different patterns "Share with accounts...." vs " "Email, federate ....", either both should be named "Share with ..." or none
  • Should "Additional shares" be hidden if none are present?
  • Share label is cut off if too long

@susnux susnux moved this to 📄 To do (~10 entries) in 📁 Files team Feb 6, 2025
@marcoambrosini
Copy link
Member

Agree with all the comments. About the input labels I would say we can modify the external shares and and say
"Share via e-mail, federated cloud id".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📄 To do (~10 entries)
Development

No branches or pull requests

3 participants