Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading output when running occ upgrade #36289

Open
te-online opened this issue Jan 22, 2023 · 1 comment · May be fixed by #49955
Open

Remove misleading output when running occ upgrade #36289

te-online opened this issue Jan 22, 2023 · 1 comment · May be fixed by #49955
Labels
3. to review Waiting for reviews enhancement feature: install and update feature: occ papercut Annoying recurring issue with possibly simple fix.

Comments

@te-online
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
When I run occ upgrade the following output is produced:

Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade

Then Nextcloud continues to run the upgrade as expected:

Setting log level to debug
Updating database schema
Updated database
Starting code integrity check...
Finished code integrity check
Update successful

Describe the solution you'd like
I think the first 2 lines of output should be removed.

In my opinion it's misleading to state "You may user your browser or the occ upgrade command" while I'm already using the "occ upgrade command" and the upgrade is in fact running.

I experience this especially when updating a nextcloud docker image as the image will run upgrade on startup automatically. Every time I inspect the logs I wonder if I need to run occ upgrade manually now or if it's already running, since the next output can take a while to show up and it often lead me to believe I need to run occ upgrade now, causing it to be run twice.

Describe alternatives you've considered
The message seems to add no value, as the user is actively performing the upgrade operation – it should be clear to the user already that an upgrade is being performed on their request.

At this time, I think the simplest solution is to remove the output.

Additional context
There are at least 2 related issues, which would benefit from removing the output:

@te-online te-online added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 22, 2023
@joshtrichards
Copy link
Member

joshtrichards commented Sep 27, 2024

@joshtrichards joshtrichards added the papercut Annoying recurring issue with possibly simple fix. label Dec 21, 2024
@joshtrichards joshtrichards added 3. to review Waiting for reviews and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: install and update feature: occ papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants