Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: nxt 30.0.4 The "Update All" button to update all apps does not work properly if I am already logged in. #49866

Open
5 of 8 tasks
tigernero79 opened this issue Dec 14, 2024 · 2 comments · May be fixed by #49902
Open
5 of 8 tasks

[Bug]: nxt 30.0.4 The "Update All" button to update all apps does not work properly if I am already logged in. #49866

tigernero79 opened this issue Dec 14, 2024 · 2 comments · May be fixed by #49902
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug feature: apps management

Comments

@tigernero79
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

Bug Description
On NC 30.0.4

When updates are available for several apps, an "Update All" button appears on the Apps > Updates page. However, clicking this button works if you are just logged in, but if you open your nextcloud that is already logged in it does not work, you have to click update all for each application that needs to be updated. Absurd behavior. In practice, if you are already logged in and click the update all button and 4 updates are available you have to click the update all button 4 times. If you log out and log back in, everything works, you just have to click update all once.

Steps to reproduce

  1. go to the updates section while already logged in (you are not logged in)
  2. Click on the update all item
  3. you will notice that you have to click the update all button as many times as there are applications to update
  4. this does not happen if you log in and then go to update, in that case everything works, just click update all once

Expected behavior

I would expect that clicking the "update all" button only once would update all applications even if I'm already logged in

Nextcloud Server version

30

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report



List of activated Apps




Nextcloud Signing status




Nextcloud Logs




Additional info


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @tigernero79
tigernero79




            added
      

  0. Needs triage

  Pending check for reproducibility or if it fits our roadmap

      

  bug


  labels


      Dec 14, 2024

    

  








      

  
      



  

  @tigernero79





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  Author


  


  

    

  





      


        


  
    

      
          
a similar issue but that has been closed is here:


#49144


only that it brings a new bug in nextcloud 30.0.4

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @tigernero79
tigernero79




        changed the title
[Bug]: The "Update all" button to update all apps does not work I'm already logged in

[Bug]: The "Update All" button to update all apps does not work properly if I am already logged in.


      Dec 14, 2024

    

  



    

    

      
    

    


      

          @tigernero79
tigernero79




        changed the title
[Bug]: The "Update All" button to update all apps does not work properly if I am already logged in.

[Bug]: nxt 30.0.4 The "Update All" button to update all apps does not work properly if I am already logged in.


      Dec 15, 2024

    

  



    


    







      

  
      



  

  @maxschmi





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
I see that in the actual version there is an erroro in the updateAll method here:

AppList.vue


this.apps
    .filter(app => app.update)
    .map((app) => limit(() => {
        this.update(app.id)
}))


It should not be this.update but app.update

So the resulting lines should be:


this.apps
    .filter(app => app.update)
    .map((app) => limit(() => {
        app.update(app.id)
}))


I'm not sure why it works for you if you just logged in. But this should fix the error.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @maxschmi
maxschmi



    linked a pull request
    
      Dec 17, 2024
    

    that will
    close
    this issue





  


  

      
   Open

  





  
  

      
        
      
      

  
    
    
  


    6 tasks
  





  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    0. Needs triage

  Pending check for reproducibility or if it fits our roadmap
  

    30-feedback

  

    bug

  

    feature: apps management









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      fix(files): updateAll method

    
      maxschmi/nextcloud-server-solve-updateAll
    





    
  




      

    

  
      

  

    

      4 participants
    

    

        
          @joshtrichards 
        
          @tigernero79 
        
          @szaimen 
        
          @maxschmi