Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

How to add an item to the list #21

Open
2 tasks
jospoortvliet opened this issue May 20, 2020 · 6 comments
Open
2 tasks

How to add an item to the list #21

jospoortvliet opened this issue May 20, 2020 · 6 comments

Comments

@jospoortvliet
Copy link
Member

jospoortvliet commented May 20, 2020

Step 0

Check these:

  • Does the provider follow our trademark guidelines - in simple terms, a provider can not use our logo or images and screenshots and text from our website without permission.
  • Can I use the logo and text of the provider (if you are not the provider yourself, you should make sure you have permission to use their logo)

Step 1

Edit the readme and add the provider you want to add in the correct way (copy and adjust another provider; make sure you add yourself in alphabetical order on name). Use this link or click the edit icon on top of the readme.
You need to be logged in for this to work!

Step 2.

Create a pull request:
Screenshot_20200520_083527
You can enter a description and see the difference:
Screenshot_20200520_085732

Step 3.

Add your logo. Now you go and move into the 'branch' you created. see where my mouse cursor is:
Screenshot_20200520_085818
You navigate into the logos folder:
Screenshot_20200520_085916
And there you upload the new file (make sure it has the right size!)
Screenshot_20200520_085943
You commit this change (the file addition) to the branch of the pull request.
Screenshot_20200520_090036

Step 4

Now you have a pull request with the image and the readme. Check if it looks good below, then click the number to go to your PR - it should be good for somebody to review and merge.
Screenshot_20200520_091755
Screenshot_20200520_091846

Good luck!

@kesselb kesselb pinned this issue May 20, 2020
@espressoelf
Copy link

espressoelf commented Jul 13, 2020

Community maintained list of Nextcloud providers

but

add yourself

So only providers are allowed to add themselves? Or are people allowed to add providers they know, too?

@jospoortvliet
Copy link
Member Author

Community maintained list of Nextcloud providers

but

add yourself

So only providers are allowed to add themselves? Or are people allowed to add providers they know, too?

Good point, yeah, I think anyone can add providers. Will update the text.

@zaclys
Copy link

zaclys commented Feb 2, 2021

Hi @jospoortvliet,

we added our request yesterday... We just hope we did it the right way : https://github.com/zaclys/providers

Best regards,
The Zaclys Team (FR)

@jospoortvliet
Copy link
Member Author

Hi @jospoortvliet,

we added our request yesterday... We just hope we did it the right way : https://github.com/zaclys/providers

Best regards,
The Zaclys Team (FR)

Hum, something went wrong, as there is no difference between your branch and ours, as in, the text and image are not there. So you didn't upload the logo or modify the readme.md.

You can do that in your own branch at https://github.com/zaclys/providers and then make a pull request (this option is just below the top of the page).

So, in simple steps:

  1. fork the repo (you did, to https://github.com/zaclys/providers)
  2. add the logo image and edit readme.md to add yourself
  3. check if it looks good in your repo (https://github.com/zaclys/providers in your case)
  4. once you are happy, choose "create a pull request":
    Screenshot_20210208_135819
  5. go through the steps and submit the pull request.

@zaclys
Copy link

zaclys commented Feb 9, 2021

Hi @jospoortvliet ,

oh sorry, first time for me using github... and did not smash that pull request button.

I hope now it's ok : 03c3bf4?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

Thanks a lot for your kind support and have a very nice day Jos !
The Zaclys Team (FR)

@zaclys
Copy link

zaclys commented Apr 12, 2021

Hi @jospoortvliet ,
we hope now our PR is ready to be approved.
Best regards,
The Zaclys Team (FR)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants