Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Open Viewer when clicking on photo in folder #2431

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: Open Viewer when clicking on photo in folder #2431

merged 2 commits into from
Apr 17, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 16, 2024 •
edited
Loading

@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Apr 16, 2024
@Pytal Pytal added this to the Nextcloud 30 milestone Apr 16, 2024
@Pytal Pytal requested review from artonge and emoral435 April 16, 2024 18:09
@Pytal Pytal self-assigned this Apr 16, 2024
@Pytal
Copy link
Member Author

Pytal commented Apr 16, 2024

/backport to stable29

@Pytal
Copy link
Member Author

Pytal commented Apr 16, 2024

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Apr 16, 2024
@Pytal Pytal enabled auto-merge April 16, 2024 18:10
@Pytal Pytal merged commit 1b4e3b5 into master Apr 17, 2024
44 checks passed
@Pytal Pytal deleted the fix/folder-viewer branch April 17, 2024 07:54
This was referenced Apr 17, 2024
Merged
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Apr 17, 2024
@aschmitz-GH
Copy link

I am using 29.0.0 and I am not able to open any file in browser, instead the files are being downloaded or when I shared a folder without permission to download, nothing happens when I click on a picture.
Affected are all file types: jpg, png, txt, pdf,...

I am not using the photos app.
Is it related to this issue or something else?

@artonge
Copy link
Collaborator

artonge commented May 13, 2024

@aschmitz-GH Probably not.

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
@barbar-binks
Copy link

I am using 29.0.0 and I am not able to open any file in browser, instead the files are being downloaded or when I shared a folder without permission to download, nothing happens when I click on a picture. Affected are all file types: jpg, png, txt, pdf,...

I am not using the photos app. Is it related to this issue or something else?

did you end up fixing this issue? happening to me in version 30.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Clicking on picture in Folders does not open viewer
4 participants
@Pytal @aschmitz-GH @artonge @barbar-binks