Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss keyboard after changing the note title #1259

Closed
ges1227 opened this issue Jun 13, 2021 · 2 comments · May be fixed by #1268
Closed

Dismiss keyboard after changing the note title #1259

ges1227 opened this issue Jun 13, 2021 · 2 comments · May be fixed by #1268
Labels
bug needs info Waiting for info from user(s). Issues with this label will auto-stale. stale UX user experience

Comments

@ges1227
Copy link

ges1227 commented Jun 13, 2021 •
edited
Loading

Please use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug

When viewing a note there is an option to click on the title in the action bar to change the name of the note.
This opens a modal and the keyboard.
After "saving" or "canceling" the title change, the modal is closed while the keyboard remains open and is not discarded.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Home Screen'
  2. Click on 'some note'
  3. Click on the title in the action bar
  4. Click on cancel or save (you don't need to change something)
  5. See the error - keyboard is still present (probably okay in edit mode, but no benefit in view mode.)

Expected behavior
The keyboard should automatically disappear after finishing the title change.

Screenshots
note-title-change note-close

Smartphone (please complete the following information):

  • Nextcloud Notes-Version F-Droid or Play Store: 3.4.8
  • Android-Version: 9
  • Device: Huawei P10
  • Keyboard: Microsoft Swift (personal opinion: should also work with Google Keyboard or any other)
@stefan-niedermann stefan-niedermann added bug UX user experience labels Jun 14, 2021
ScottieKim added a commit to ScottieKim/nextcloud-notes that referenced this issue Jun 17, 2021
@ScottieKim
Update: Issue nextcloud#1259, Dismiss keyboard after changing the not…
7d12408 
…e title
AndyScherzinger pushed a commit to ScottieKim/nextcloud-notes that referenced this issue Jan 21, 2024
@ScottieKim @AndyScherzinger
Update: Issue nextcloud#1259, Dismiss keyboard after changing the not…
f70ff8a 
…e title
@joshtrichards joshtrichards linked a pull request Aug 9, 2024 that will close this issue
Update: Issue #1259, Dismiss keyboard after changing the note title #1268
Open
@joshtrichards
Copy link
Member

I'm not seeing this behavior today. Are you still experiencing it?

@joshtrichards joshtrichards added the needs info Waiting for info from user(s). Issues with this label will auto-stale. label Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@github-actions github-actions bot added the stale label Sep 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs info Waiting for info from user(s). Issues with this label will auto-stale. stale UX user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Issue #1259, Dismiss keyboard after changing the note title ScottieKim/nextcloud-notes
3 participants
@joshtrichards @stefan-niedermann @ges1227