Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal links like footnotes don't work as expected #2003

Open
3 tasks done
edent opened this issue Dec 1, 2022 · 2 comments
Open
3 tasks done

Internal links like footnotes don't work as expected #2003

edent opened this issue Dec 1, 2022 · 2 comments
Labels
API Impact API/Backend code bug frontend impact Javascript/Frontend code

Comments

@edent
Copy link

edent commented Dec 1, 2022

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

I have a blog feed which includes internal links - primarily footnotes. When I click on a link to a footnote, it does not scroll down to the correct part of the page. Instead, it opens a new window and displays the article again.

I think this may be similar to #1952.

Steps to Reproduce

Explain what you did to encounter the issue

  1. Subscribe to my blog feed https://shkspr.mobi/blog/feed/atom/
  2. One of the internal links will be something like <sup><a href="#fn-43921-simplified" title="Read footnote.">1</a></sup>
  3. Click on the link.
  4. The page should scroll down to the id later in the page: <li id="fn-43921-simplified">...</li>
  5. However, I think the parser removes the ids from elements in the feed.
  6. The browser opens a new tab and reloads the same article.

System Information

  • News app version: 19.0.0
  • Nextcloud version: 24.0.7
  • Cron type: Hetzner
  • PHP version: Hetzner
  • Database and version: Hetzner
  • Browser and version: Firefox 107
  • OS and version: Ubuntu 22
@edent edent added the bug label Dec 1, 2022
@Grotax
Copy link
Member

Grotax commented Dec 1, 2022

Yea I think there might be no way to do this.
Allowing feeds to insert random ids into the client might end badly.

@Grotax Grotax added API Impact API/Backend code frontend impact Javascript/Frontend code labels Dec 1, 2022
@IgorA100
Copy link
Contributor

IgorA100 commented Feb 13, 2023

This issue has nothing to do with #1952
It seems the tag IDs are being lost in the plugin.
..................
Yes, to read the BODY, the "readability.php" library is used, which apparently removes ID tags. In principle, this is true, because they may conflict with the IDs used by NextCloud. On the other hand, you can change the ID during import (for example, add a suffix associated with the URL of the article source). But... it needs to be discussed here: https://github.com/fivefilters/readability.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Impact API/Backend code bug frontend impact Javascript/Frontend code
Projects
None yet
Development

No branches or pull requests

3 participants