Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markdown in chat messages #1929

Open
provokateurin opened this issue Apr 15, 2024 · 3 comments · May be fixed by #2647
Open

Support markdown in chat messages #1929

provokateurin opened this issue Apr 15, 2024 · 3 comments · May be fixed by #2647
Assignees
Labels
feature New feature or request package: talk_app

Comments

@provokateurin
Copy link
Member

This might be hard to implement because it has to work on top of our rich objects stuff.

@provokateurin
Copy link
Member Author

Likely needs to use the low level APIs from https://github.com/flutter/packages/blob/main/packages/flutter_markdown/lib/src/builder.dart, but I think it should be possible. Alternatively we could reverse it and integrate our rich object rendering as custom elements in the markdown rendering. The second option is probably easier if it is possible, but makes us a lot more dependent on the flutter_markdown package which I don't like.

@provokateurin
Copy link
Member Author

Unfortunately https://pub.dev/packages/flutter_markdown doesn't give use the low level control we need and also misses features like flutter/flutter#81739.
So we have to implement something custom, but can work with https://pub.dev/packages/markdown and copy a lot of code from https://pub.dev/packages/flutter_markdown.
We can probably also skip implementing some parts, since Talk web also only supports a limited set of features.

@provokateurin provokateurin self-assigned this Nov 2, 2024
@provokateurin
Copy link
Member Author

All supported features are tested in https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/cypress/component/richtext.cy.ts, so we can implement the same subset of features (and test them as well).

@provokateurin provokateurin linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request package: talk_app
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant