New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation entry is missing required field `app` #769

Open

susnux opened this issue Aug 27, 2024 · 2 comments

susnux commented Aug 27, 2024 •

edited

Loading

The navigation entry registration is missing the required app field (required since NC28):

external/lib/AppInfo/Application.php

Line 76 in d9de3e5

return [

There should be 'app' => 'external'.

The text was updated successfully, but these errors were encountered:

Member

provokateurin commented Aug 27, 2024

I wonder if this was done on purpose for some reason, @nickvergessen do you maybe remember?
I haven't yet seen that this causes any problems.

Member

nickvergessen commented Aug 27, 2024

app field was not required/existing back then.
Compared to the remaining 7yo code, the 10 months is the difference:
https://github.com/nextcloud/server/blame/0a7fcde9069ff05cffe22e2ad6831d866103d12c/lib/private/NavigationManager.php#L377-L378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment