Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon doesn't display #188

Open
eauchat opened this issue Apr 13, 2020 · 13 comments
Open

Icon doesn't display #188

eauchat opened this issue Apr 13, 2020 · 13 comments

Comments

@eauchat
Copy link

eauchat commented Apr 13, 2020

Steps to reproduce

  1. update nextcloud to 18.0.2 (from version 15)
  2. update "External Sites" app
  3. log in to nextcloud — the link to the the external site shows, but no icon
  4. open "External Sites" admin settings — any icon that is added, shows a broken img

Expected behaviour

The icon should display properly in the topbar's general view.
Adding an icon in the "External sites" admin options should show non broken img sources.
It should be possible to remove added icons using the little trash button.

Actual behaviour

There is no icon in the topbar (but the text of the external site shows when hovering over the button).
All icons in the "External Sites" admin settings show a broken source.
Clicking on the little trash icon to remove a previously uploaded icon doesn't do anything.

Server configuration

Operating system: yunohost 3.7.1.1 (Debian 9)
Web server: ?
Database: mysql 10.1.44
PHP version: 7.3.16
Nextcloud version: 18.0.2

Where did you install Nextcloud from: yunohost app store see here for details

App enabled

Accessibility 1.4.0
Activity 2.11.0
AppOrder 0.9.0
Auditing / Logging 1.8.0
Calendar 2.0.3
Circles 0.18.4
Collaborative tags 1.8.0
Comments 1.8.0
Contacts 3.2.0
Deleted files 1.8.0
Draw.io 0.9.5
External sites 3.5.0
External storage support 1.9.0
External user authentication 0.9.1
Federation 1.8.0
File sharing 1.10.1
First run wizard 2.7.0
LDAP user and group backend 1.8.0
Log Reader 2.3.0
Markdown Editor 2.2.0
Monitoring 1.8.0
Music 0.13.2
News 14.1.3
Nextcloud announcements 1.7.0
Notifications 2.6.0
ONLYOFFICE 4.1.4
Ownpad 0.6.14
Password policy 1.8.0
PDF viewer 1.7.0
Photos 1.0.0
Privacy 1.2.0
Recommendations 0.6.0
Right click 0.15.2
Share by mail 1.8.0
Support 1.1.0
Text 2.0.0
Theming 1.9.0
Update notification 1.8.0
Usage survey 1.6.0
Versions 1.11.0
Video player 1.7.0

Client configuration

Browser: firefox 75
Operating system: ubuntu 18

@Glunk
Copy link

Glunk commented Apr 29, 2020

I have the same issue after updating from 15.0.14 to 18.0.2
Server returns a 404 for each icon in apps/external/icons, whether the icons were uploaded before or after the update to nextcloud 18.

@ChildishGiant
Copy link

image

Same issue on Nextcloud 18.0.2, external sites 3.5.0

@nickvergessen
Copy link
Member

Is there an error in your nextcloud.log file about this?

@eauchat
Copy link
Author

eauchat commented Jun 25, 2020

Where is supposed to be this file? I don't seem to have any file named like this in my server.
The folder /var/log/nextcloud is empty, in my case.

@nickvergessen
Copy link
Member

inside your data directory

@eauchat
Copy link
Author

eauchat commented Sep 21, 2020

inside your data directory

I just tried to add an icon and nothing was being logged in the nextcloud.log file.

@nickvergessen
Copy link
Member

I need more infos to reproduce this.

Can you check the browser console (press F12), switch to the network tab and reload the page. Then filter for images and search for external/icons.

@eauchat
Copy link
Author

eauchat commented Jan 4, 2021

So doing what you asked @nickvergessen, this is what I get:

The icons listed in the page fail to be fetched (404 status).

The url to the icons failing to be fetched look like this:

https://domain.tld/apps/external/icons/external-dark.svg
https://domain.tld/apps/external/icons/earth.svg
...

But I noticed that the external-dark icon seemed to be also asked by another part of the page, and that request succeeds (200 status). The successful request url is: https://domain.tld/apps/external/img/external-dark.svg.
But maybe that's unrelated and those two external-dark icons are totally different files (https://domain.tld/apps/external/img/earth.svg for example gives a 404 if I try to open it in a tab).

If you need any details from the failing requests, I can give them, but most of the headers seem more to give private information about the setup, and I'm not sure they'd be helpful for you.

@nickvergessen
Copy link
Member

do the files exist in data/appdata_*****/external/icons/

@eauchat
Copy link
Author

eauchat commented Jan 10, 2021

do the files exist in data/appdata_*****/external/icons/

Yes, they do.

@Glunk
Copy link

Glunk commented Jan 15, 2021

The issue for me was fixed after I update to nextcloud 20 (external sites 3.7.1) and re-upload the icons files.

@2muchgit
Copy link

2muchgit commented Aug 12, 2022

Nextcloud Hub II 23.0.7
External sites 3.10.2

I would just like to say I had the same issue and it was related with name of the file.
I tried to a favicon 32x32 with dashes and it did not work. Ex:. favicon-bag-of-cash.png
As soon as I changed that to: favicon_bag_of_cash.png the External Sites Application loaded the image with no further issues.
I hope this helps.

@red3333
Copy link

red3333 commented Aug 2, 2023

Nextcloud Hub 5 (27.0.1)
External sites 5.2.0

Same problem here (icon does not load, the name is really basic: "jellyfin.svg").
The admin user is not affected (all icons display correctly)
Simple user does not display any icon from "external sites", not even Nextcloud ones (eg. "external.svg").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants