Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify origin of request when search for users #2370

Open
ArtificialOwl opened this issue Jul 22, 2021 · 2 comments · May be fixed by #4261
Open

specify origin of request when search for users #2370

ArtificialOwl opened this issue Jul 22, 2021 · 2 comments · May be fixed by #4261
Labels
3. to review Waiting for reviews bug Something isn't working feature: circles

Comments

@ArtificialOwl
Copy link
Member

It would help to have a confirmation that the request is coming from the Contacts App when running

GET /ocs/v2.php/apps/files_sharing/api/v1/sharees?format=json&itemType=file&search=test&perPage=25&shareType[]=0&shareType[]=1&shareType[]=4&shareType[]=7&lookup=false

The idea is that when sharing a file, the same request is executed and should only returns Circles to which the current user is a member. But in the contacts app, the request should returns also visible Circles, in case the current user wants to add a Circles he is not currently member as a Member.

I think changing the itemType from 'file to contacts will be enough.
It is not the perfect solution but it will work better, unless we switch to another endpoint to catch the list of users.

Right now, this is how the Circles App detect the origin of the request is from the contacts app:
https://github.com/nextcloud/circles/pull/724/files#diff-85950fb08bcb016579e9da6fb82f2335314fe42638d0ae76f5cb8828681ebfb8R101-R103
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Jul 27, 2021 •
edited
Loading

on a side note, if a 'source' param can be added, or included in the itemType with the singleId of the current Circle, I could filter Circles that cannot be added as Members of the current Circles: A Local Circle cannot add another Non-Local Circle

@ArtificialOwl ArtificialOwl mentioned this issue Aug 10, 2021
Merged
@hamza221 hamza221 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage labels Dec 19, 2024
@hamza221
Copy link
Contributor

itemType: file is still used
https://github.com/nextcloud/contacts/blob/main/src/services/collaborationAutocompletion.js#L86

@hamza221 hamza221 linked a pull request Dec 19, 2024 that will close this issue
Open
@hamza221 hamza221 added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: circles
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: specify origin of request when search for users nextcloud/contacts
3 participants
@ArtificialOwl @kesselb @hamza221